Skip to content

run rustfmt on librustc_lint folder - #33931

Closed
srinivasreddy wants to merge 1 commit into
rust-lang:masterfrom
srinivasreddy:lint_folder
Closed

run rustfmt on librustc_lint folder#33931
srinivasreddy wants to merge 1 commit into
rust-lang:masterfrom
srinivasreddy:lint_folder

Conversation

@srinivasreddy

@srinivasreddysrinivasreddy commented May 28, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented May 28, 2016

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez

GuillaumeGomez commented May 28, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented May 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 68641d8 has been approved by GuillaumeGomez

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 68641d8 with merge c87acad...

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt-rustbuild

@GuillaumeGomez

GuillaumeGomez commented May 29, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: save-temps was moved under the -C switch #33902

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 68641d8 has been approved by GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented May 29, 2016

Copy link
Copy Markdown
Member

@bors: retry

@GuillaumeGomezGuillaumeGomez mentioned this pull request May 29, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33931- srinivasreddy:lint_folder, r=Guilla…
6839fcd
…umeGomez
run rustfmt on librustc_lint folder
bors added a commit that referenced this pull request May 29, 2016
@bors
Auto merge of#33948- GuillaumeGomez:rollup, r=GuillaumeGomez
1d78a61
Rollup of 10 pull requests
- Successful merges: #33793, #33893, #33902, #33912, #33913, #33914, #33917, #33931, #33937, #33938
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33931- srinivasreddy:lint_folder, r=Guilla…
1bbbd5d
…umeGomez
run rustfmt on librustc_lint folder
@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #33929) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez

GuillaumeGomez commented May 30, 2016

Copy link
Copy Markdown
Member

@bors: r-

@srinivasreddy

srinivasreddy commented May 30, 2016

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez roll up please. 😄

@GuillaumeGomez

GuillaumeGomez commented May 30, 2016

Copy link
Copy Markdown
Member

First, please squash your commits. Then we wait for travis status and after that we roll it up! (The path to r+ is long and difficult but it's worth it haha.)

@srinivasreddy

srinivasreddy commented May 30, 2016

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez

Haha.

62157175

@srinivasreddy

srinivasreddy commented Jun 7, 2016

Copy link
Copy Markdown
ContributorAuthor

@GuillaumeGomez Done. roll up please.

@GuillaumeGomez

GuillaumeGomez commented Jun 7, 2016

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Jun 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 9b014ec has been approved by GuillaumeGomez

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 8, 2016
@Manishearth
Rollup merge ofrust-lang#33931- srinivasreddy:lint_folder, r=Guilla…
94cae0a
…umeGomez
run rustfmt on librustc_lint folder
@bors

bors commented Jun 9, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #32202) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Jun 10, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #34095) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Jul 19, 2016

Copy link
Copy Markdown
Member

Closing due to inactivity, but feel free to reopen with a rebase!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srinivasreddy@rust-highfive@GuillaumeGomez@bors@alexcrichton@arielb1