Skip to content

Improve E0133 error explanation - #33913

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:improve_e0133
May 30, 2016
Merged

Improve E0133 error explanation#33913
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:improve_e0133

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented May 27, 2016

Copy link
Copy Markdown
Member

steveklabnik
steveklabnik reviewed May 27, 2016
View reviewed changes
Comment threadsrc/librustc/diagnostics.rs Outdated

@steveklabniksteveklabnikMay 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"outside of an unsafe function"

@steveklabnik

steveklabnik commented May 27, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented May 27, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c848ca1 has been approved by steveklabnik

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c848ca1 with merge 340c589...

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-opt-rustbuild

@GuillaumeGomez

GuillaumeGomez commented May 29, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@bors: r+ rollup

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: save-temps was moved under the -C switch #33902

@bors

bors commented May 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c848ca1 has been approved by GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented May 29, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: retry

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33913- GuillaumeGomez:improve_e0133, r=Gui…
06c9d0e
…llaumeGomez
Improve E0133 error explanation
r? @steveklabnik
@GuillaumeGomezGuillaumeGomez mentioned this pull request May 29, 2016
Closed
bors added a commit that referenced this pull request May 29, 2016
@bors
Auto merge of#33948- GuillaumeGomez:rollup, r=GuillaumeGomez
1d78a61
Rollup of 10 pull requests
- Successful merges: #33793, #33893, #33902, #33912, #33913, #33914, #33917, #33931, #33937, #33938
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33913- GuillaumeGomez:improve_e0133, r=Gui…
7475236
…llaumeGomez
Improve E0133 error explanation
r? @steveklabnik
@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c848ca1 with merge 77c5a95...

@bors

bors commented May 30, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-cross-netbsd

@GuillaumeGomez

GuillaumeGomez commented May 30, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request May 30, 2016
@Manishearth
Rollup merge ofrust-lang#33913- GuillaumeGomez:improve_e0133, r=Gui…
6c6dcc9
…llaumeGomez
Improve E0133 error explanation
r? @steveklabnik
@ManishearthManishearth mentioned this pull request May 30, 2016
Merged
bors added a commit that referenced this pull request May 30, 2016
@bors
Auto merge of#33959- Manishearth:rollup, r=Manishearth
5da602b
Rollup of 8 pull requests
- Successful merges: #33793, #33893, #33912, #33913, #33914, #33917, #33937, #33938
- Failed merges:
@bors
bors merged commit c848ca1 into rust-lang:masterMay 30, 2016
@GuillaumeGomez
GuillaumeGomez deleted the improve_e0133 branch May 30, 2016 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez@steveklabnik@bors