Skip to content

std: Use memalign, not posix_memalign, on Android - #33832

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:android-memalign
May 28, 2016
Merged

std: Use memalign, not posix_memalign, on Android#33832
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:android-memalign

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented May 24, 2016

Copy link
Copy Markdown
Member

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the posix_memalign API wasn't implemented yet. Thankfully,
however, the memalign API was and it appears to be usable with free on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.

@rust-highfive

rust-highfive commented May 24, 2016

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana

luqmana commented May 24, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented May 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 6584fb4 has been approved by luqmana

@GuillaumeGomezGuillaumeGomez mentioned this pull request May 24, 2016
Merged
@GuillaumeGomez

GuillaumeGomez commented May 24, 2016

Copy link
Copy Markdown
Member

@bors: r-

Some tests failed.

@nagisa

nagisa commented May 24, 2016

Copy link
Copy Markdown
Member

This is certainly a dangerous commit to put into rollup.

@bors rollup-

@nagisa

nagisa commented May 24, 2016

Copy link
Copy Markdown
Member

@bors r+ rollup-

Test failure in the rollup seems to have nothing to do with this change.

@bors

bors commented May 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 6584fb4 has been approved by nagisa

@nagisa

nagisa commented May 24, 2016

Copy link
Copy Markdown
Member

@bors r=luqmana

Err.

@bors

bors commented May 24, 2016

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented May 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 6584fb4 has been approved by luqmana

bors added a commit that referenced this pull request May 24, 2016
@bors
Auto merge of#33833- GuillaumeGomez:rollup, r=GuillaumeGomez
8393d99
Rollup of 7 pull requests
- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
@alexcrichtonalexcrichton mentioned this pull request May 24, 2016
Merged
@alexcrichton

alexcrichton commented May 24, 2016

Copy link
Copy Markdown
MemberAuthor

Nominating for beta based on this comment: #33848 (comment)

@alexcrichtonalexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 24, 2016
@alexcrichton
std: Use memalign, not posix_memalign, on Android
33dfd0f
We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).
This should help fix some of the last few test failures when compiling against
API level 9.
@alexcrichton

alexcrichton commented May 24, 2016

Copy link
Copy Markdown
MemberAuthor

@bors: r=luqmana 33dfd0f

@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 26, 2016
@nikomatsakis

nikomatsakis commented May 26, 2016

Copy link
Copy Markdown
Contributor

Unclear that we are the right team to make this call, but the compiler team approves backporting to beta. :) Ordinarily we wouldn't backport this change, but since it helps with the bot infrastructure, seems fine.

@alexcrichton

alexcrichton commented May 26, 2016

Copy link
Copy Markdown
MemberAuthor

Oh right, yes sorry I intended to discuss this with the tools team this coming triage meeting.

@ManishearthManishearth mentioned this pull request May 28, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request May 28, 2016
@Manishearth
Rollup merge ofrust-lang#33832- alexcrichton:android-memalign, r=lu…
320dd04
…qmana
std: Use memalign, not posix_memalign, on Android
We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).
This should help fix some of the last few test failures when compiling against
API level 9.
bors added a commit that referenced this pull request May 28, 2016
@bors
Auto merge of#33927- Manishearth:rollup, r=Manishearth
f1776fe
Rollup of 15 pull requests
- Successful merges: #33820, #33821, #33822, #33824, #33825, #33831, #33832, #33848, #33849, #33852, #33854, #33856, #33859, #33860, #33861
- Failed merges:
@bors
bors merged commit 33dfd0f into rust-lang:masterMay 28, 2016
@alexcrichton
alexcrichton deleted the android-memalign branch May 31, 2016 21:07
@alexcrichtonalexcrichton mentioned this pull request May 31, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 31, 2016
@sanxiynsanxiyn mentioned this pull request Oct 7, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@alexcrichton@rust-highfive@luqmana@bors@GuillaumeGomez@nagisa@nikomatsakis@brson