Uh oh!
There was an error while loading. Please reload this page.
test: Use set sysroot for more NDK compatibility - #33848
Conversation
Recent versions of the Android NDK no longer ship debuggers like `arm-linux-androideabi-gdb`, but instead one prebuilt binary `gdb`. We can symlink this into place at least to get our detection still working, but it now needs to be told what the sysroot is so it can correctly do... something. Long story short, tests didn't pass with this change and after this change they pass.
rust-highfive
commented
May 24, 2016
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 24, 2016
This, in combination with #33832 should enable us to move to the r11c NDK and API level 9 for our Android builders |
michaelwoerister
commented
May 24, 2016
@bors: r+ |
bors
commented
May 24, 2016
📌 Commit 0f3e865 has been approved by |
alexcrichton
commented
May 24, 2016
Ok, I've now verified that this plus #33832 gets a green build on Android, bringing improvements like:
I haven't deployed the buildbot changes just yet, and I'm hesitant to do so. These two changes are required and not present on the beta branch, so if we upgrade buildbot we'll be unable to build a new beta compiler (unless we use a different image to build a beta compiler than the nightly compiler. To me, there's a few courses of action to take here:
My preferred course of action is (2) as it's the easiest and probably doesn't have any impact anyway. This change isn't related to the build at all and #33832 should in theory be pretty minor as well. As a result I'm going to beta-nominate this and that, and we can discuss. |
alexcrichton
commented
May 24, 2016
(for those cc'd, see my previous comment) cc @froydnj - going back to API level 9 |
froydnj
commented
May 25, 2016
This seems like a reasonable course of action for propagating Android changes sooner. |
michaelwoerister
commented
May 25, 2016
Given the minor impact of the changes, backporting seems fine to me. |
Nercury
commented
May 26, 2016
In this case, we should also get libc tests going on Android's AArch64. |
bors
commented
May 29, 2016
…rister test: Use `set sysroot` for more NDK compatibility Recent versions of the Android NDK no longer ship debuggers like `arm-linux-androideabi-gdb`, but instead one prebuilt binary `gdb`. We can symlink this into place at least to get our detection still working, but it now needs to be told what the sysroot is so it can correctly do... something. Long story short, tests didn't pass with this change and after this change they pass.
Recent versions of the Android NDK no longer ship debuggers like
arm-linux-androideabi-gdb, but instead one prebuilt binarygdb. We cansymlink this into place at least to get our detection still working, but it now
needs to be told what the sysroot is so it can correctly do... something. Long
story short, tests didn't pass with this change and after this change they pass.