Uh oh!
There was an error while loading. Please reload this page.
save-analysis: be a bit more defensive with field sub-expressions - #33859
Merged
Conversation
Prevents an ice with `(...).f` since the sub-expression is in the AST but not the HIR. We could actually do better in this specific case, but it doesn't seem worth it.
rust-highfive
commented
May 25, 2016
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
pnkfelix
commented
May 25, 2016
Contributor
@bors r+ |
bors
commented
May 25, 2016
Collaborator
📌 Commit c8ee3f2 has been approved by |
bors added a commit
that referenced
this pull request
May 28, 2016
bors
commented
May 29, 2016
Collaborator
⌛ Testing commit c8ee3f2 with merge ae10b4a... |
bors
commented
May 29, 2016
Collaborator
💔 Test failed - auto-linux-64-opt-rustbuild |
eddyb
commented
May 29, 2016
Contributor
@bors retry |
bors
commented
May 29, 2016
Collaborator
bors added a commit
that referenced
this pull request
May 29, 2016
save-analysis: be a bit more defensive with field sub-expressions Prevents an ice with `(...).f` since the sub-expression is in the AST but not the HIR. We could actually do better in this specific case, but it doesn't seem worth it.
bors
commented
May 29, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents an ice with
(...).fsince the sub-expression is in the AST but not the HIR.We could actually do better in this specific case, but it doesn't seem worth it.