Skip to content

doc: Mention that writeln! and println! always use LF - #34777

Merged
bors merged 1 commit into
rust-lang:masterfrom
glandium:issue34697
Jul 15, 2016
Merged

doc: Mention that writeln! and println! always use LF#34777
bors merged 1 commit into
rust-lang:masterfrom
glandium:issue34697

Conversation

@glandium

@glandiumglandium commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

Fixes#34697

I'm not really satisfied with the wording, but I didn't have a better idea. Suggestions welcome.

@rust-highfive

rust-highfive commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Jul 12, 2016
View reviewed changes
Comment threadsrc/libstd/macros.rs
}

/// Macro for printing to the standard output, with a newline.
/// Macro for printing to the standard output, with a newline. On all

@GuillaumeGomezGuillaumeGomezJul 12, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"On every platforms" maybe?

@alexcrichtonalexcrichtonJul 12, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colloquially to me I think "On all platforms" makes a little more sense than "on every platforms"

@GuillaumeGomezGuillaumeGomezJul 12, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's all good for me. 😉

@alexcrichton

alexcrichton commented Jul 12, 2016

Copy link
Copy Markdown
Member

r? @GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented Jul 12, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Jul 12, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 4bfaa43 has been approved by GuillaumeGomez

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jul 14, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 15, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#34777- glandium:issue34697, r=GuillaumeGomez
d607e28
doc: Mention that writeln! and println! always use LF
Fixesrust-lang#34697
I'm not really satisfied with the wording, but I didn't have a better idea. Suggestions welcome.
bors added a commit that referenced this pull request Jul 15, 2016
@bors
Auto merge of#34819- GuillaumeGomez:rollup, r=GuillaumeGomez
3cc3ad1
Rollup of 7 pull requests
- Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818
- Failed merges: #33951
@bors
bors merged commit 4bfaa43 into rust-lang:masterJul 15, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@glandium@rust-highfive@alexcrichton@GuillaumeGomez@bors