Skip to content

Add doc example for std::process::ExitStatus::success. - #34794

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:exitstatus-success
Jul 15, 2016
Merged

Add doc example for std::process::ExitStatus::success.#34794
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:exitstatus-success

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@frewsxcv

frewsxcv commented Jul 12, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

retep998
retep998 reviewed Jul 13, 2016
View reviewed changes
Comment threadsrc/libstd/process.rs Outdated

@retep998retep998Jul 13, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this perhaps be just "mkdir"? Surely we can assume that it is in the path, and it would avoid platform specific paths. Then again, there isn't actually a mkdir program on Windows, just a command in shells like cmd or powershell.

@frewsxcvfrewsxcvJul 13, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this perhaps be just "mkdir"? Surely we can assume that it is in the path, and it would avoid platform specific paths.

Updated to just be mkdir.

Then again, there isn't actually a mkdir program on Windows, just a command in shells like cmd or powershell.

If you have a more cross platform suggestion for this example, let me know.

@frewsxcv
frewsxcvforce-pushed the exitstatus-success branch from 87d3ce4 to 27e44edCompareJuly 13, 2016 01:32
@GuillaumeGomez

GuillaumeGomez commented Jul 13, 2016

Copy link
Copy Markdown
Member

I wonder if we should put a note or something for the command.

@frewsxcv

frewsxcv commented Jul 13, 2016

Copy link
Copy Markdown
ContributorAuthor

For what it's worth, all the Command doc examples are in a similar scenario:

https://doc.rust-lang.org/std/process/struct.Command.html

@GuillaumeGomez

GuillaumeGomez commented Jul 13, 2016

Copy link
Copy Markdown
Member

Right, I guess it's enough.

Thanks!

@bors: r+ rollup

@bors

bors commented Jul 13, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 27e44ed has been approved by GuillaumeGomez

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jul 14, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 15, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#34794- frewsxcv:exitstatus-success, r=Guil…
367f942
…laumeGomez
Add doc example for `std::process::ExitStatus::success`.
None
bors added a commit that referenced this pull request Jul 15, 2016
@bors
Auto merge of#34819- GuillaumeGomez:rollup, r=GuillaumeGomez
3cc3ad1
Rollup of 7 pull requests
- Successful merges: #34456, #34733, #34777, #34794, #34799, #34804, #34818
- Failed merges: #33951
@bors
bors merged commit 27e44ed into rust-lang:masterJul 15, 2016
@frewsxcv
frewsxcv deleted the exitstatus-success branch October 2, 2016 23:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frewsxcv@GuillaumeGomez@bors@retep998