Uh oh!
There was an error while loading. Please reload this page.
Conversation
rust-highfive
commented
Jul 20, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
apasel422
commented
Jul 20, 2016
@bors: r+ rollup Thanks! |
bors
commented
Jul 20, 2016
📌 Commit e91b625 has been approved by |
apasel422
commented
Jul 20, 2016
@bors: r- |
steveklabnik
commented
Jul 20, 2016
Gah! Thanks! @bors: r+ rollup |
bors
commented
Jul 20, 2016
📌 Commit e91b625 has been approved by |
| /// This sort of behavior has been known to [lead to privilege escalation] when | ||
| /// used incorrectly, for example. | ||
| /// | ||
| /// [lead to privledge escalation]: http://securityvulns.com/Wdocument183.html |
There was a problem hiding this comment.
Could you update this too, so that the link still works?
steveklabnik
commented
Jul 20, 2016
@bors: r- whoops, @apasel422 i will let you have this PR, I didn't see that. lol! |
apasel422
commented
Aug 6, 2016
@qOLOp Are you still interested in fixing this? |
ghost
commented
Aug 11, 2016
@apasel422 Sorry about that, I have just fixed the second typo. |
apasel422
commented
Aug 11, 2016
bors
commented
Aug 11, 2016
📌 Commit 629f2aa has been approved by |
Fix typo (privledge->privilege)
Fix typo (privledge->privilege)
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
No description provided.