Uh oh!
There was an error while loading. Please reload this page.
Implement From for Cell, RefCell and UnsafeCell - #35392
Conversation
rust-highfive
commented
Aug 5, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexcrichton
commented
Aug 7, 2016
Thanks for the PR! Looks good to me, and I'm tagging as T-libs to ensure the rest of @rust-lang/libs sees this as well |
brson
commented
Aug 11, 2016
bors
commented
Aug 11, 2016
📌 Commit 1403df7 has been approved by |
Implement From for Cell, RefCell and UnsafeCell Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
bors
commented
Aug 13, 2016
⌛ Testing commit 1403df7 with merge ea78bd9... |
bors
commented
Aug 13, 2016
💔 Test failed - auto-linux-64-debug-opt |
alexcrichton
commented
Aug 14, 2016
@bors: retry On Sat, Aug 13, 2016 at 8:33 AM, bors notifications@github.com wrote:
|
eddyb
commented
Aug 14, 2016
@bors rollup |
Implement From for Cell, RefCell and UnsafeCell Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
Implement From for Cell, RefCell and UnsafeCell Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
Considering that
Fromis implemented forBox,RcandArc, it seems reasonable to implement it forCell,RefCellandUnsafeCell.