Skip to content

Updates compiler error E0040 with new format - #35357

Merged
bors merged 1 commit into
rust-lang:masterfrom
shri3k:E0040
Aug 7, 2016
Merged

Updates compiler error E0040 with new format#35357
bors merged 1 commit into
rust-lang:masterfrom
shri3k:E0040

Conversation

@shri3k

@shri3kshri3k commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Addresses #35208 as part of #35233.
r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

GuillaumeGomez commented Aug 5, 2016

Copy link
Copy Markdown
Member

Thanks!

Can you update the corresponding test file in compile-fail directory please?

@shri3k

shri3k commented Aug 5, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Yeah, it seems I forgot to update that on both of my PRs. I'll go ahead and update this later tonight. Thank you for catching it. 😳

@shri3k

shri3k commented Aug 6, 2016

Copy link
Copy Markdown
ContributorAuthor

I was able to find only one test file corresponding to this error. Updated it.

r? @GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented Aug 6, 2016

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Aug 6, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit e5a4a7a has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35357- shri3k:E0040, r=GuillaumeGomez
ef75709
Updates compiler error E0040 with new format
Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
KiChjang
KiChjang reviewed Aug 7, 2016
View reviewed changes
Comment threadsrc/test/compile-fail/E0040.rs Outdated
fn main() {
let mut x = Foo { x: -7 };
x.drop(); //~ ERROR E0040
x.drop();

@KiChjangKiChjangAug 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace on this line.

@shri3kshri3kAug 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. 😅 Sorry.

@sanxiyn

sanxiyn commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

@bors r-

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Aug 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b564c6a has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35357- shri3k:E0040, r=jonathandturner
feb458d
Updates compiler error E0040 with new format
Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35357- shri3k:E0040, r=jonathandturner
b69b2db
Updates compiler error E0040 with new format
Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Merged
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of#35469- jonathandturner:rollup, r=jonathandturner
1744c46
Rollup of 21 pull requests
- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors
bors merged commit b564c6a into rust-lang:masterAug 7, 2016
@KiChjangKiChjang mentioned this pull request Aug 8, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shri3k@rust-highfive@GuillaumeGomez@bors@sanxiyn@sophiajt@KiChjang