Skip to content

Update E0101 and E0102 to new format - #35443

Merged
bors merged 1 commit into
rust-lang:masterfrom
franleplant:master
Aug 7, 2016
Merged

Update E0101 and E0102 to new format#35443
bors merged 1 commit into
rust-lang:masterfrom
franleplant:master

Conversation

@franleplant

@franleplantfranleplant commented Aug 7, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #35233
Fixes#35243
Fixes#35244
r? @jonathandturner

PS: My first contribution

@rust-highfive

rust-highfive commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Looks good! And welcome aboard! 🎉

@bors r+ rollup

@bors

bors commented Aug 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 0e9cbf6 has been approved by jonathandturner

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

@bors r-

Oops! I just noticed one little thing. Would you mind fixing them before I send this in?

sophiajt
sophiajt reviewed Aug 7, 2016
View reviewed changes
Comment threadsrc/test/compile-fail/E0101.rs Outdated

@sophiajtsophiajtAug 7, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this //~| NOTE cannot resolve type of expression instead?

@franleplant

franleplant commented Aug 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Done Sir!

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Thanks! That looks good. One last thing. Can you squash your 2 commits down 1 one?

With that I think it'll be ready.

@franleplant

franleplant commented Aug 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Done! 😄

@sophiajt

sophiajt commented Aug 7, 2016

Copy link
Copy Markdown
Contributor

Alright, now it looks good!

@bors r+ rollup

@bors

bors commented Aug 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit da86ae2 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35443- franleplant:master, r=jonathandturner
a6cf011
Update E0101 and E0102 to new format
Part of rust-lang#35233Fixesrust-lang#35243Fixesrust-lang#35244
r? @jonathandturner
PS: My first contribution
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Merged
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of#35469- jonathandturner:rollup, r=jonathandturner
1744c46
Rollup of 21 pull requests
- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors
bors merged commit da86ae2 into rust-lang:masterAug 7, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franleplant@rust-highfive@sophiajt@bors