Skip to content

Updated error message E0282 - #35366

Merged
bors merged 1 commit into
rust-lang:masterfrom
medzin:E0282
Aug 7, 2016
Merged

Updated error message E0282#35366
bors merged 1 commit into
rust-lang:masterfrom
medzin:E0282

Conversation

@medzin

@medzinmedzin commented Aug 5, 2016

Copy link
Copy Markdown

Fixes#35312 as part of #35233.

r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 5, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Looks good!

One small request. I think I was asleep when I wrote the original issue. Can we change it from: "cannot infer type about _" to "cannot infer type for _"

Sorry about that :)

@sophiajt

sophiajt commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Great, thanks for updating it!

@bors r+ rollup

@medzin

medzin commented Aug 5, 2016

Copy link
Copy Markdown
Author

@jonathandturner fixed! :)

@bors

bors commented Aug 5, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ff96b56 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 5, 2016
Jonathan Turner
Rollup merge ofrust-lang#35366- medzin:E0282, r=jonathandturner
2139a0a
Updated error message E0282
Fixesrust-lang#35312 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 5, 2016
Closed
@sophiajt

sophiajt commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

@bors r-

Looks like I jumped the gun. Just let me know when you're ready.

@medzin

medzin commented Aug 5, 2016

Copy link
Copy Markdown
Author

@jonathandturner all tests are green now :)

@sophiajt

sophiajt commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Sounds good!

@bors r+ rollup

@bors

bors commented Aug 5, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit cb90cce has been approved by jonathandturner

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of#35397- jonathandturner:rollup, r=jonathandturner
43446fc
Rollup of 18 pull requests
- Successful merges: #34916, #35287, #35288, #35331, #35353, #35356, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35394
- Failed merges: #35395
@eddybeddyb mentioned this pull request Aug 6, 2016
Merged
@GuillaumeGomez

GuillaumeGomez commented Aug 6, 2016

Copy link
Copy Markdown
Member

@bors: r-

Please squash your last commit.

@medzin

medzin commented Aug 6, 2016

Copy link
Copy Markdown
Author

@GuillaumeGomez only last or all to one?

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of#35407- eddyb:rollup, r=eddyb
444ff9f
Rollup of 21 pull requests
- Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394
- Failed merges: #35331, #35395
@GuillaumeGomez

GuillaumeGomez commented Aug 6, 2016

Copy link
Copy Markdown
Member

All to one please.

@medzin

medzin commented Aug 6, 2016

Copy link
Copy Markdown
Author

@GuillaumeGomez done

@sophiajt

sophiajt commented Aug 6, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 6, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 19e4579 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35366- medzin:E0282, r=jonathandturner
4985246
Updated error message E0282
Fixesrust-lang#35312 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35366- medzin:E0282, r=jonathandturner
5b22d2b
Updated error message E0282
Fixesrust-lang#35312 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Jonathan Turner
Rollup merge ofrust-lang#35366- medzin:E0282, r=jonathandturner
94cb842
Updated error message E0282
Fixesrust-lang#35312 as part of rust-lang#35233.
r? @GuillaumeGomez
@sophiajtsophiajt mentioned this pull request Aug 7, 2016
Merged
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of#35469- jonathandturner:rollup, r=jonathandturner
1744c46
Rollup of 21 pull requests
- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors
bors merged commit 19e4579 into rust-lang:masterAug 7, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@medzin@rust-highfive@sophiajt@bors@GuillaumeGomez