Skip to content

Fix documentation in cell mod - #35895

Merged
bors merged 1 commit into
rust-lang:masterfrom
F001:patch-1
Aug 30, 2016
Merged

Fix documentation in cell mod#35895
bors merged 1 commit into
rust-lang:masterfrom
F001:patch-1

Conversation

@F001

@F001F001 commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

The implementation of Rc type in this doc is outdated.

@rust-highfive

rust-highfive commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Aug 22, 2016
View reviewed changes
Comment threadsrc/libcore/cell.rs Outdated

@GuillaumeGomezGuillaumeGomezAug 22, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding pub in here?

@F001F001Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. The pub keyword is removed.

@steveklabnik

steveklabnik commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Seems like the build failure is spurious.

I share @GuillaumeGomez 's question about pub, but otherwise looks good to me

@GuillaumeGomez

GuillaumeGomez commented Aug 22, 2016

Copy link
Copy Markdown
Member

Travis failed. Run:

make tidy

to see what's wrong.

@steveklabnik

steveklabnik commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

Hm, still a strange failure. Let's see how it does on real CI, thanks!

@bors: r+ rollup

@bors

bors commented Aug 23, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 424698b has been approved by steveklabnik

eddyb
eddyb reviewed Aug 23, 2016
View reviewed changes
Comment threadsrc/libcore/cell.rs Outdated

@eddybeddybAug 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still over 100 columns wide, please split into multiple lines.

@eddyb

eddyb commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

@bors r-

@GuillaumeGomez

GuillaumeGomez commented Aug 23, 2016

Copy link
Copy Markdown
Member

And run make tidy.

@GuillaumeGomez

GuillaumeGomez commented Aug 24, 2016

Copy link
Copy Markdown
Member

And please squash your commits.

@F001

F001 commented Aug 29, 2016

Copy link
Copy Markdown
ContributorAuthor

@steveklabnik Just Ping. Could you please help to merge this PR?

@eddyb

eddyb commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@bors r=steveklabnik

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit f4c55dd has been approved by steveklabnik

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f4c55dd with merge 404d580...

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1

arielb1 commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@bors retry

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#35895- F001:patch-1, r=steveklabnik
ab5e229
Fix documentation in cell mod
The implementation of Rc type in this doc is outdated.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#35895- F001:patch-1, r=steveklabnik
290095d
Fix documentation in cell mod
The implementation of Rc type in this doc is outdated.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
badf406
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#35895- F001:patch-1, r=steveklabnik
325b711
Fix documentation in cell mod
The implementation of Rc type in this doc is outdated.
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
4473130
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@bors
bors merged commit f4c55dd into rust-lang:masterAug 30, 2016
@F001
F001 deleted the patch-1 branch August 31, 2016 01:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@F001@rust-highfive@steveklabnik@GuillaumeGomez@bors@eddyb@arielb1@aturon