Skip to content

Update E0194 to new error format - #36056

Merged
bors merged 1 commit into
rust-lang:masterfrom
leikahing:E0194_new_error_format
Aug 30, 2016
Merged

Update E0194 to new error format#36056
bors merged 1 commit into
rust-lang:masterfrom
leikahing:E0194_new_error_format

Conversation

@leikahing

@leikahingleikahing commented Aug 27, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#35280 to update E0194 to support new error message format. Part of #35233.

A separate Github issue #36057 tracks the bonus portion of the original ticket.

r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@leikahing

leikahing commented Aug 27, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @jonathandturner

@sophiajt

sophiajt commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

Looks good!

@bors r+ rollup

@bors

bors commented Aug 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit eea03f5 has been approved by jonathandturner

@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 29, 2016
Closed
@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eea03f5 with merge 4852d09...

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1

arielb1 commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@bors retry rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36056- birryree:E0194_new_error_format, r=…
11992c9
…jonathandturner
Update E0194 to new error format
Fixesrust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.
A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 29, 2016
@bors
Auto merge of#36090- GuillaumeGomez:rollup, r=GuillaumeGomez
aee9774
Rollup of 11 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35962, #35977, #35993, #35997, #36054, #36056, #36070
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36056- birryree:E0194_new_error_format, r=…
29c53a8
…jonathandturner
Update E0194 to new error format
Fixesrust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.
A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.
r? @jonathandturner
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
badf406
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36056- birryree:E0194_new_error_format, r=…
751e4db
…jonathandturner
Update E0194 to new error format
Fixesrust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.
A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
4473130
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@leikahingleikahing mentioned this pull request Aug 30, 2016
Closed
@bors
bors merged commit eea03f5 into rust-lang:masterAug 30, 2016
@leikahing
leikahing deleted the E0194_new_error_format branch August 30, 2016 20:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@leikahing@rust-highfive@sophiajt@bors@arielb1@nikomatsakis