Skip to content

Update E0089 to new error format - #36103

Merged
bors merged 1 commit into
rust-lang:masterfrom
swr1bm86:fix-E0089
Aug 30, 2016
Merged

Update E0089 to new error format#36103
bors merged 1 commit into
rust-lang:masterfrom
swr1bm86:fix-E0089

Conversation

@swr1bm86

@swr1bm86swr1bm86 commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

Fixes#35227.
Part of #35233.

r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@swr1bm86swr1bm86 changed the title Update E0089 to new error format[WIP] Update E0089 to new error formatAug 29, 2016
@sophiajt

sophiajt commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

@zjhmale - looks good so far. Are you still working on this?

@swr1bm86swr1bm86 changed the title [WIP] Update E0089 to new error formatUpdate E0089 to new error formatAug 29, 2016
@swr1bm86

swr1bm86 commented Aug 29, 2016

Copy link
Copy Markdown
ContributorAuthor

@jonathandturner just update it, please review 😄

@sophiajt

sophiajt commented Aug 29, 2016

Copy link
Copy Markdown
Contributor

Great :)

@bors r+ rollup

@bors

bors commented Aug 29, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 01083ba has been approved by jonathandturner

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36103- zjhmale:fix-E0089, r=jonathandturner
0ff8a6a
Update E0089 to new error format
Fixesrust-lang#35227.
Part of rust-lang#35233.
r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36103- zjhmale:fix-E0089, r=jonathandturner
21e2155
Update E0089 to new error format
Fixesrust-lang#35227.
Part of rust-lang#35233.
r? @jonathandturner
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
badf406
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#36103- zjhmale:fix-E0089, r=jonathandturner
9a3cfe9
Update E0089 to new error format
Fixesrust-lang#35227.
Part of rust-lang#35233.
r? @jonathandturner
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of#36126- GuillaumeGomez:rollup, r=GuillaumeGomez
4473130
Rollup of 16 pull requests
- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@bors
bors merged commit 01083ba into rust-lang:masterAug 30, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swr1bm86@rust-highfive@sophiajt@bors