Uh oh!
There was an error while loading. Please reload this page.
accumulate vector and assert for RangeFrom and RangeInclusive examples - #35758
Merged
bors merged 1 commit intoAug 31, 2016
Merged
Conversation
rust-highfive
commented
Aug 17, 2016
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
matthew-piziak
commented
Aug 17, 2016
ContributorAuthor
GuillaumeGomez
commented
Aug 17, 2016
Member
Thanks! @bors: r+ rollup |
bors
commented
Aug 17, 2016
Collaborator
📌 Commit 6c0186d has been approved by |
Contributor
There was a problem hiding this comment.
I think removing the annotation changes it from u8 to implicitly i32, not that it matters.
There was a problem hiding this comment.
It simplified the example without harming so I didn't bother with it.
ContributorAuthor
There was a problem hiding this comment.
Yeah, sorry, I should have been clear. Removing the annotation isn't a no-op for the code, but it's unnecessary for explaining the behavior of step_by in this case. A u8 example may be important for explaining overflow behavior though...
bors
commented
Aug 17, 2016
Collaborator
☔ The latest upstream changes (presumably #35747) made this pull request unmergeable. Please resolve the merge conflicts. |
matthew-piziakforce-pushed
the
vec-assert-over-println-remaining
branch
from
August 17, 2016 22:53
6c0186d to
95c53b1CompareGuillaumeGomez
commented
Aug 19, 2016
Member
@bors: r+ rollup |
bors
commented
Aug 19, 2016
Collaborator
📌 Commit 95c53b1 has been approved by |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
GuillaumeGomez
commented
Aug 23, 2016
Member
Please squash your two last commits. |
matthew-piziakforce-pushed
the
vec-assert-over-println-remaining
branch
2 times, most recently
from
August 23, 2016 21:08
7636be9 to
28f057dComparesteveklabnik
commented
Aug 25, 2016
Contributor
@bors: r=GuillaumeGomez rollup |
bors
commented
Aug 25, 2016
Collaborator
📌 Commit 28f057d has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 25, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 26, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
bors
commented
Aug 26, 2016
Collaborator
⌛ Testing commit 28f057d with merge 1d3d70e... |
bors
commented
Aug 26, 2016
Collaborator
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`. add `fn main` wrappers to enable Rust Playground "Run" button
matthew-piziakforce-pushed
the
vec-assert-over-println-remaining
branch
from
August 26, 2016 15:54
28f057d to
50e0fbcComparematthew-piziak
commented
Aug 26, 2016
ContributorAuthor
GuillaumeGomez
commented
Aug 29, 2016
Member
Once buildbot is fixed, r+ you get! |
steveklabnik
commented
Aug 30, 2016
Contributor
@bors: r=GuillaumeGomez rollup |
bors
commented
Aug 30, 2016
Collaborator
📌 Commit 50e0fbc has been approved by |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
bors added a commit
that referenced
this pull request
Aug 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #35695 for
Rangewas merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation forRangeFromandRangeInclusive. It also removes what looks to be an erroneously commented line for#![feature(step_by)], and an unnecessary primitive-type annotation in0u8...