Uh oh!
There was an error while loading. Please reload this page.
Update E0318 to new format - #36079
Conversation
rust-highfive
commented
Aug 28, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
acrrd
commented
Aug 29, 2016
It was to underline the same part that the error do. |
GuillaumeGomez
commented
Aug 29, 2016
Thanks! @bors: r+ rollup |
bors
commented
Aug 29, 2016
📌 Commit ef3a34a has been approved by |
…Gomez Update E0318 to new format Fixesrust-lang#35322. Part of rust-lang#35233. r? @GuillaumeGomez
GuillaumeGomez
commented
Aug 30, 2016
@bors: r- Error: ---- [compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs stdout ----
error: C:/bot/slave/auto-win-gnu-32-opt-rustbuild/build/src/test/compile-fail/typeck-default-trait-impl-outside-crate.rs:13: expected error not found: `Copy` trait not defined in this crate
error: 0 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: PATH="C:\bot\slave\..."
not found errors (from test file): [
Error {
line_num: 13,
kind: Some(
Error
),
msg: "`Copy` trait not defined in this crate"
}
]
thread '[compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs' panicked at 'explicit panic', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\tools\compiletest\src\runtest.rs:1084
failures:
[compile-fail] compile-fail\typeck-default-trait-impl-outside-crate.rs
test result: FAILED. 2524 passed; 1 failed; 12 ignored; 0 measured |
Sorry about that, I pushed the fix and run the correct test this time. |
GuillaumeGomez
commented
Aug 30, 2016
Have you tested it? I wonder if it was waiting for a note or an error. It's not very clear... |
Before I put an ERROR in the test, now I put NOTE and works. |
GuillaumeGomez
commented
Aug 31, 2016
Fine by me then. Thanks! @bors: r+ rollup |
bors
commented
Aug 31, 2016
📌 Commit bdfcd78 has been approved by |
…Gomez Update E0318 to new format Fixesrust-lang#35322. Part of rust-lang#35233. r? @GuillaumeGomez
…Gomez Update E0318 to new format Fixesrust-lang#35322. Part of rust-lang#35233. r? @GuillaumeGomez
Fixes#35322.
Part of #35233.
r? @GuillaumeGomez