Skip to content

E0513 - #36723

Merged
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:e0513
Sep 27, 2016
Merged

E0513#36723
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:e0513

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Sep 25, 2016

Copy link
Copy Markdown
Member

@sophiajt

sophiajt commented Sep 25, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@GuillaumeGomez To finish this up, you should also put a label on the error span, since this comes from the "put labels on all the errors" list (#35233 (comment)) :)

Maybe something like:

 |
103 | mem::transmute_copy::<&[u8; hdr_sz], GelfChunkHeader>(&b[..hdr_sz]);
| ^^^^^^ no type for variable

TimNN
TimNN reviewed Sep 25, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/diagnostics.rs Outdated

@TimNNTimNNSep 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "found out" I think.

TimNN
TimNN reviewed Sep 25, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/diagnostics.rs Outdated

@TimNNTimNNSep 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be "please use a constant size"

@GuillaumeGomez

GuillaumeGomez commented Sep 26, 2016

Copy link
Copy Markdown
MemberAuthor

Updated.

@sophiajt

sophiajt commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 26, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 96a0f06 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 26, 2016
Jonathan Turner
Rollup merge ofrust-lang#36723- GuillaumeGomez:e0513, r=jonathandtu…
5f84df6
…rner
E0513
Part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Sep 26, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 27, 2016
Jonathan Turner
Rollup merge ofrust-lang#36723- GuillaumeGomez:e0513, r=jonathandtu…
9b72650
…rner
E0513
Part of rust-lang#35233
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Sep 27, 2016
Merged
bors added a commit that referenced this pull request Sep 27, 2016
@bors
Auto merge of#36764- jonathandturner:rollup, r=jonathandturner
ec7679b
Rollup of 14 pull requests
- Successful merges: #36563, #36574, #36586, #36662, #36663, #36669, #36676, #36721, #36723, #36727, #36729, #36742, #36754, #36756
- Failed merges:
@bors
bors merged commit 96a0f06 into rust-lang:masterSep 27, 2016
@GuillaumeGomez
GuillaumeGomez deleted the e0513 branch September 27, 2016 13:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@TimNNTimNNTimNN left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@sophiajt@bors@TimNN