Skip to content

librustdoc refactoring and cleanup. - #36729

Merged
bors merged 6 commits into
rust-lang:masterfrom
frewsxcv:rustdoc
Sep 27, 2016
Merged

librustdoc refactoring and cleanup.#36729
bors merged 6 commits into
rust-lang:masterfrom
frewsxcv:rustdoc

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Sep 25, 2016

Copy link
Copy Markdown
Contributor

See each commit for more information. Biggest changes here is the addition of a passes module and each pass now lives in its own submodule.

@frewsxcv

frewsxcv commented Sep 25, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@rust-highfive

rust-highfive commented Sep 25, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

GuillaumeGomez commented Sep 25, 2016

Copy link
Copy Markdown
Member

Wo nice! 👍 for me but I'll let the last words to @alexcrichton.

r? @alexcrichton

@alexcrichton

alexcrichton commented Sep 26, 2016

Copy link
Copy Markdown
Member

@bors: r+

Thanks @frewsxcv!

@bors

bors commented Sep 26, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 99e1b9c has been approved by alexcrichton

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 27, 2016
Jonathan Turner
Rollup merge ofrust-lang#36729- frewsxcv:rustdoc, r=alexcrichton
ee2e115
librustdoc refactoring and cleanup.
See each commit for more information. Biggest changes here is the addition of a `passes` module and each pass now lives in its own submodule.
@sophiajtsophiajt mentioned this pull request Sep 27, 2016
Merged
bors added a commit that referenced this pull request Sep 27, 2016
@bors
Auto merge of#36764- jonathandturner:rollup, r=jonathandturner
ec7679b
Rollup of 14 pull requests
- Successful merges: #36563, #36574, #36586, #36662, #36663, #36669, #36676, #36721, #36723, #36727, #36729, #36742, #36754, #36756
- Failed merges:
@bors
bors merged commit 99e1b9c into rust-lang:masterSep 27, 2016
@frewsxcv
frewsxcv deleted the rustdoc branch September 27, 2016 13:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frewsxcv@rust-highfive@GuillaumeGomez@alexcrichton@bors@steveklabnik