Uh oh!
There was an error while loading. Please reload this page.
Extend preprocessor LLVM version checks to support LLVM 4.x - #36742
Merged
Conversation
rust-highfive
commented
Sep 26, 2016
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
commented
Sep 26, 2016
Contributor
cc #36295 |
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Thanks @shepmaster! Looks great to me.
Member
There was a problem hiding this comment.
Could this entire clause also be wrapped in parens? (yay C macros)
same below as well
MemberAuthor
There was a problem hiding this comment.
Done!
Someone should really work on creating a replacement for this C language thing.
Member
There was a problem hiding this comment.
Perhaps this could be LLVM_VERSION_GE?
Similar to ParialOrd::ge naming at least
This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
shepmasterforce-pushed
the
llvm-4-preamble
branch
from
September 26, 2016 17:40
c7341e5 to
e6e117cComparealexcrichton
commented
Sep 26, 2016
Member
@bors: r+ |
bors
commented
Sep 26, 2016
Collaborator
📌 Commit e6e117c has been approved by |
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 26, 2016
…richton Extend preprocessor LLVM version checks to support LLVM 4.x This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
sophiajt pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 27, 2016
…richton Extend preprocessor LLVM version checks to support LLVM 4.x This doesn't actually do anything for LLVM 4.x yet, but sets the stage.
bors added a commit
that referenced
this pull request
Sep 27, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't actually do anything for LLVM 4.x yet, but sets the stage.