Add Vec::dedup_by and Vec::dedup_by_key by SimonSapin · Pull Request #36743 · rust-lang/rust

SimonSapin · 2016-09-26T16:30:25Z

No description provided.

test_dedup_shared has been exactly the same as test_dedup_unique since 6f16df4, three years ago.

rust-highfive · 2016-09-26T16:30:32Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

SimonSapin · 2016-09-26T16:31:52Z

In the spirit of #35856.

(Separate commits show smaller diffs.)

alexcrichton · 2016-09-27T17:55:05Z

Seems like a reasonable addition to me!

cc @rust-lang/libs

aturon · 2016-09-27T18:59:02Z

I'm 👍 on this addition.

alexcrichton · 2016-10-03T23:53:30Z

@rfcbot fcp merge

rfcbot · 2016-10-03T23:53:40Z

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

alexcrichton · 2016-10-03T23:54:53Z

Also we'll need to be sure to add a tracking issue for these, but I'm fine with that happening just before merge

SimonSapin · 2016-10-04T12:03:45Z

I’ll open a tracking issue and edit the PR to reference it when (if) this addition is accepted.

alexcrichton · 2016-10-10T23:08:19Z

@SimonSapin ok, want to update with an unstable issue reference? I'll r+ after

The show up separately in rustdoc. This is a separate commit to keep the previous one’s diff shorter.

SimonSapin · 2016-10-11T12:41:08Z

Done: #37087.

alexcrichton · 2016-10-11T14:49:13Z

@bors: r+

bors · 2016-10-11T14:49:16Z

📌 Commit 401f1c4 has been approved by alexcrichton

Add Vec::dedup_by and Vec::dedup_by_key

Rollup of 10 pull requests - Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067 - Failed merges:

bors · 2016-10-12T16:58:06Z

⌛ Testing commit 401f1c4 with merge 4655164...

bors · 2016-10-12T17:58:01Z

💔 Test failed - auto-win-msvc-64-cargotest

SimonSapin · 2016-10-12T18:34:30Z

failures:
---- wrong_checksum_is_an_error stdout ----
thread 'wrong_checksum_is_an_error' panicked at 'failed to remove dir C:\bot\slave\auto-win-msvc-64-cargotest\build\obj\build\ct\cargo\target\cit\t0\bar\target\debug\deps: The directory is not empty. (os error 145)', tests\cargotest\support\paths.rs:143
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
wrong_checksum_is_an_error
test result: FAILED. 6 passed; 1 failed; 0 ignored; 0 measured
command did not execute successfully: "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\cargotest.exe" "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\x86_64-pc-windows-msvc\\stage0/bin\\cargo.exe" "C:\\bot\\slave\\auto-win-msvc-64-cargotest\\build\\obj\\build\\ct"
expected success, got: exit code: 101
Makefile:51: recipe for target 'check-cargotest' failed

Is this an intermittent failure?

alexcrichton · 2016-10-13T05:56:38Z

@bors: retry

bors · 2016-10-13T05:56:40Z

⌛ Testing commit 401f1c4 with merge a37d74b...

Add Vec::dedup_by and Vec::dedup_by_key

bors · 2016-10-13T06:24:20Z

💔 Test failed - auto-linux-cross-opt

arielb1 · 2016-10-13T16:39:40Z

@bors retry

bors · 2016-10-13T17:02:24Z

⌛ Testing commit 401f1c4 with merge 3ab1839...

bors · 2016-10-13T18:51:15Z

💔 Test failed - auto-linux-cross-opt

alexcrichton · 2016-10-13T20:23:09Z

@bors: retry

bors · 2016-10-14T02:56:53Z

⌛ Testing commit 401f1c4 with merge 17af6b9...

Add Vec::dedup_by and Vec::dedup_by_key

bors · 2016-10-14T09:23:17Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 17af6b9 to master...

rfcbot · 2016-10-17T01:04:28Z

All relevant subteam members have reviewed. No concerns remain.

rfcbot · 2016-10-24T01:06:06Z

It has been one week since all blocks to the FCP were resolved.

SimonSapin added 2 commits September 26, 2016 18:15

Remove duplicate test.
dc97341
test_dedup_shared has been exactly the same as test_dedup_unique since 6f16df4, three years ago.

Move Vec::dedup tests from slice.rs to vec.rs
f14f4db

rust-highfive assigned aturon Sep 26, 2016

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 27, 2016

SimonSapin mentioned this pull request Oct 11, 2016
Tracking issue for Vec::dedup_by and Vec::dedup_by_key #37087
Closed

SimonSapin added 2 commits October 11, 2016 14:39

Add Vec::dedup_by and Vec::dedup_by_key
be34bac

Merge two impl<T> Vec<T> blocks.
401f1c4
The show up separately in rustdoc. This is a separate commit to keep the previous one’s diff shorter.

SimonSapin force-pushed the dedup-by branch from 9b61f1e to 401f1c4Compare October 11, 2016 12:40

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 11, 2016
Rollup merge ofrust-lang#36743- SimonSapin:dedup-by, r=alexcrichton
10d7e12
Add Vec::dedup_by and Vec::dedup_by_key

sophiajt mentioned this pull request Oct 11, 2016
Rollup of 10 pull requests #37093
Closed

bors added a commit that referenced this pull request Oct 12, 2016
Auto merge of#37093- jonathandturner:rollup, r=jonathandturner
ccb8b3e
Rollup of 10 pull requests - Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067 - Failed merges:

bors added a commit that referenced this pull request Oct 13, 2016
Auto merge of#36743- SimonSapin:dedup-by, r=alexcrichton
a37d74b
Add Vec::dedup_by and Vec::dedup_by_key

bors added a commit that referenced this pull request Oct 14, 2016
Auto merge of#36743- SimonSapin:dedup-by, r=alexcrichton
17af6b9
Add Vec::dedup_by and Vec::dedup_by_key

bors merged commit 401f1c4 into rust-lang:masterOct 14, 2016

SimonSapin deleted the dedup-by branch December 7, 2016 03:15

mbrubeck mentioned this pull request Sep 29, 2017
Provide Vec::dedup_by in addition to Vec::dedup rust-lang/rfcs#1301
Closed

ronnodas mentioned this pull request Mar 10, 2025
Itertools::dedup_by[_key] vs Vecrust-itertools/itertools#930
Open

Uh oh!

Uh oh!

Conversation

SimonSapin commented Sep 26, 2016

Uh oh!

rust-highfive commented Sep 26, 2016

Uh oh!

SimonSapin commented Sep 26, 2016

Uh oh!

alexcrichton commented Sep 27, 2016

Uh oh!

aturon commented Sep 27, 2016

Uh oh!

alexcrichton commented Oct 3, 2016

Uh oh!

rfcbot commented Oct 3, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Oct 3, 2016

Uh oh!

SimonSapin commented Oct 4, 2016

Uh oh!

alexcrichton commented Oct 10, 2016

Uh oh!

SimonSapin commented Oct 11, 2016

Uh oh!

alexcrichton commented Oct 11, 2016

Uh oh!

bors commented Oct 11, 2016

Uh oh!

bors commented Oct 12, 2016

Uh oh!

bors commented Oct 12, 2016

Uh oh!

SimonSapin commented Oct 12, 2016

Uh oh!

alexcrichton commented Oct 13, 2016

Uh oh!

bors commented Oct 13, 2016

Uh oh!

bors commented Oct 13, 2016

Uh oh!

arielb1 commented Oct 13, 2016

Uh oh!

bors commented Oct 13, 2016

Uh oh!

bors commented Oct 13, 2016

Uh oh!

alexcrichton commented Oct 13, 2016

Uh oh!

bors commented Oct 14, 2016

Uh oh!

bors commented Oct 14, 2016

Uh oh!

rfcbot commented Oct 17, 2016

Uh oh!

rfcbot commented Oct 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rfcbot commented Oct 3, 2016•
edited
Loading