Add two functions to check type of SockAddr by achanda · Pull Request #36762 · rust-lang/rust

achanda · 2016-09-27T00:17:48Z

These can be used to determine the type of the underlying IP
address

alexcrichton · 2016-09-27T16:53:54Z

Thanks! I might prefer to call this is_ipv4 or is_ipv6 to be clear what the "v" is as well, but otherwise looks reasonable to me.

cc @rust-lang/libs

achanda · 2016-09-27T17:07:20Z

Updated both!

aturon · 2016-09-27T19:01:36Z

I'm 👍 on these additions.

achanda · 2016-09-29T22:09:40Z

And this one too!

alexcrichton · 2016-10-03T23:53:01Z

@rfcbot fcp merge

We'll want to file a tracking issue for these APIs as well, but that can happen just before merging

rfcbot · 2016-10-03T23:53:40Z

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

These can be used to determine the type of the underlying IP address

alexcrichton · 2016-10-10T23:08:33Z

@bors: r+

bors · 2016-10-10T23:08:34Z

📌 Commit d9e6430 has been approved by alexcrichton

bors · 2016-10-11T05:20:58Z

⌛ Testing commit d9e6430 with merge 17c1d39...

bors · 2016-10-11T08:17:02Z

💔 Test failed - auto-win-gnu-32-opt

alexcrichton · 2016-10-11T14:49:55Z

@bors: retry

On Tue, Oct 11, 2016 at 1:17 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5858
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36762 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95P9ZDemSzcLge68n98Oav_oR64peks5qy0YBgaJpZM4KHIcu
.

@alexcrichton

Add two functions to check type of SockAddr These can be used to determine the type of the underlying IP address r? @alexcrichton

Rollup of 10 pull requests - Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067 - Failed merges:

@alexcrichton

Add two functions to check type of SockAddr These can be used to determine the type of the underlying IP address r? @alexcrichton

bors · 2016-10-12T18:28:54Z

⌛ Testing commit d9e6430 with merge 9cb0136...

@alexcrichton

Add two functions to check type of SockAddr These can be used to determine the type of the underlying IP address r? @alexcrichton

bors · 2016-10-12T21:42:10Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 9cb0136 to master...

Rollup of 17 pull requests - Successful merges: #36762, #36831, #36973, #36991, #36995, #37023, #37049, #37050, #37056, #37064, #37066, #37067, #37084, #37089, #37091, #37092, #37110 - Failed merges:

rfcbot · 2016-10-17T07:13:01Z

@alexcrichton proposal cancelled.

rust-highfive assigned alexcrichton Sep 27, 2016

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 27, 2016

achanda force-pushed the sockaddr_type branch from aa54b9c to ee51b2cCompare September 27, 2016 17:04

Add two functions to check type of SockAddr
d9e6430
These can be used to determine the type of the underlying IP address

achanda force-pushed the sockaddr_type branch from ee51b2c to d9e6430Compare October 4, 2016 04:12

achanda mentioned this pull request Oct 4, 2016
Tracking issue for {IpAddr,SockAddr}::ip_v{4,6} methods #36949
Closed

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 11, 2016
Rollup merge ofrust-lang#36762- achanda:sockaddr_type, r=alexcrichton
6f81f2f
Add two functions to check type of SockAddr These can be used to determine the type of the underlying IP address r? @alexcrichton

sophiajt mentioned this pull request Oct 11, 2016
Rollup of 10 pull requests #37093
Closed

bors added a commit that referenced this pull request Oct 12, 2016
Auto merge of#37093- jonathandturner:rollup, r=jonathandturner
ccb8b3e
Rollup of 10 pull requests - Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067 - Failed merges:

alexcrichton mentioned this pull request Oct 12, 2016
Rollup of 17 pull requests #37118
Merged

bors added a commit that referenced this pull request Oct 12, 2016
Auto merge of#36762- achanda:sockaddr_type, r=alexcrichton
9cb0136
Add two functions to check type of SockAddr These can be used to determine the type of the underlying IP address r? @alexcrichton

bors merged commit d9e6430 into rust-lang:masterOct 12, 2016

achanda deleted the sockaddr_type branch October 12, 2016 21:43

Uh oh!

Uh oh!

Conversation

achanda commented Sep 27, 2016

Uh oh!

alexcrichton commented Sep 27, 2016

Uh oh!

achanda commented Sep 27, 2016

Uh oh!

aturon commented Sep 27, 2016

Uh oh!

achanda commented Sep 29, 2016

Uh oh!

alexcrichton commented Oct 3, 2016

Uh oh!

rfcbot commented Oct 3, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Oct 10, 2016

Uh oh!

bors commented Oct 10, 2016

Uh oh!

bors commented Oct 11, 2016

Uh oh!

bors commented Oct 11, 2016

Uh oh!

alexcrichton commented Oct 11, 2016

Uh oh!

bors commented Oct 12, 2016

Uh oh!

bors commented Oct 12, 2016

Uh oh!

rfcbot commented Oct 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rfcbot commented Oct 3, 2016•
edited
Loading