Skip to content

macros: expand #[derive]s after other attribute macros and improve intra-#[derive] ordering - #37067

Merged
bors merged 2 commits into
rust-lang:masterfrom
jseyfried:expand_derives_last
Oct 13, 2016
Merged

macros: expand #[derive]s after other attribute macros and improve intra-#[derive] ordering#37067
bors merged 2 commits into
rust-lang:masterfrom
jseyfried:expand_derives_last

Conversation

@jseyfried

@jseyfriedjseyfried commented Oct 10, 2016

Copy link
Copy Markdown
Contributor

@jseyfriedjseyfried changed the title macros: expand #[derive]s after other macro invocations and improve intra-#[derive] orderingmacros: expand #[derive]s after other attribute macros and improve intra-#[derive] orderingOct 10, 2016
@alexcrichton

alexcrichton commented Oct 10, 2016

Copy link
Copy Markdown
Member

@bors: r+

Thanks @jseyfried!

@bors

bors commented Oct 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 8aa6b5c has been approved by alexcrichton

@nikomatsakisnikomatsakis mentioned this pull request Oct 10, 2016
Closed
53 tasks
@dtolnaydtolnay mentioned this pull request Oct 10, 2016
Closed
sgrif
sgrif reviewed Oct 10, 2016
View reviewed changes
Comment threadsrc/libsyntax_ext/deriving/mod.rs Outdated

@sgrifsgrifOct 10, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use Iterator#partition instead?

@jseyfriedjseyfriedOct 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, amended.

@jseyfried

jseyfried commented Oct 10, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors r=alexcrichton

@bors

bors commented Oct 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 448d6ad has been approved by alexcrichton

@jseyfried

jseyfried commented Oct 10, 2016

Copy link
Copy Markdown
ContributorAuthor

cc @nrc

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 11, 2016
Jonathan Turner
Rollup merge ofrust-lang#37067- jseyfried:expand_derives_last, r=al…
3cf07a8
…excrichton
macros: expand `#[derive]`s after other attribute macros and improve intra-`#[derive]` ordering
Fixesserde-rs/serde#577.
cc rust-lang#35900
r? @alexcrichton
@sophiajtsophiajt mentioned this pull request Oct 11, 2016
Closed
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of#37093- jonathandturner:rollup, r=jonathandturner
ccb8b3e
Rollup of 10 pull requests
- Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067
- Failed merges:
@alexcrichtonalexcrichton mentioned this pull request Oct 12, 2016
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 12, 2016
@alexcrichton
Rollup merge ofrust-lang#37067- jseyfried:expand_derives_last, r=al…
2d71be5
…excrichton
macros: expand `#[derive]`s after other attribute macros and improve intra-`#[derive]` ordering
Fixesserde-rs/serde#577.
cc rust-lang#35900
r? @alexcrichton
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of#37118- alexcrichton:rollup, r=alexcrichton
d34318d
Rollup of 17 pull requests
- Successful merges: #36762, #36831, #36973, #36991, #36995, #37023, #37049, #37050, #37056, #37064, #37066, #37067, #37084, #37089, #37091, #37092, #37110
- Failed merges:
@bors
bors merged commit 448d6ad into rust-lang:masterOct 13, 2016
@jseyfried
jseyfried deleted the expand_derives_last branch October 16, 2016 05:43
@jseyfriedjseyfried mentioned this pull request Feb 9, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sgrifsgrifsgrif left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jseyfried@alexcrichton@bors@sgrif