Skip to content

Improvements to 'include' macro documentation. - #38457

Merged
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:include
Jan 19, 2017
Merged

Improvements to 'include' macro documentation.#38457
bors merged 3 commits into
rust-lang:masterfrom
frewsxcv:include

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@frewsxcv

frewsxcv commented Dec 18, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I'm open to a different example if someone has a better idea.

@frewsxcv

frewsxcv commented Dec 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors delegate=kmcallister

@bors

bors commented Dec 18, 2016

Copy link
Copy Markdown
Collaborator

✌️ @kmcallister can now approve this pull request

durka
durka approved these changes Dec 21, 2016
View reviewed changes

@durkadurka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's worth including a warning about #35560? (i.e. don't include! a file with more than one statement in it)

Comment threadsrc/libstd/macros.rs Outdated

@durkadurkaDec 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantically, I guess it will actually print "Hello World!"

Comment threadsrc/libstd/macros.rs Outdated

@durkadurkaDec 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix the small typo on the next line (should be "unhygienically")

@frewsxcv

frewsxcv commented Dec 21, 2016

Copy link
Copy Markdown
ContributorAuthor

@durka Thanks for the feedback! Comments have been addressed.

@frewsxcv

frewsxcv commented Jan 16, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented Jan 17, 2017

Copy link
Copy Markdown
Member

Thanks for the examples and the fixes!

@bors: r+ rollup

@bors

bors commented Jan 17, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4a354ab has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 19, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#38457- frewsxcv:include, r=GuillaumeGomez
ced04ff
Improvements to 'include' macro documentation.
None
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 19, 2017
Merged
bors added a commit that referenced this pull request Jan 19, 2017
@bors
Auto merge of#39180- GuillaumeGomez:rollup, r=GuillaumeGomez
47965f5
Rollup of 11 pull requests
- Successful merges: #38457, #38922, #38970, #39039, #39091, #39115, #39121, #39149, #39150, #39151, #39165
- Failed merges:
@bors
bors merged commit 4a354ab into rust-lang:masterJan 19, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@durkadurkadurka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frewsxcv@bors@GuillaumeGomez@durka