Skip to content

A few improvements to the slice docs. - #39165

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:slice
Jan 19, 2017
Merged

A few improvements to the slice docs.#39165
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:slice

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jan 18, 2017

Copy link
Copy Markdown
Contributor
  • Simplify Option::iter_mut doc example.
  • Document 'empty' corner-cases for slice::{starts_with, ends_with}.
  • Indicate 'true' as code-like.

@rust-highfive

rust-highfive commented Jan 18, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

frewsxcv commented Jan 18, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=GuillaumeGomez rollup

@bors

bors commented Jan 18, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 745bffd has been approved by GuillaumeGomez

@frewsxcv

frewsxcv commented Jan 18, 2017

Copy link
Copy Markdown
ContributorAuthor

See also #39147

@frewsxcv
A few improvements to the slice docs.
c8822da
* Simplify `Option::iter_mut` doc example.
* Document 'empty' corner-cases for `slice::{starts_with, ends_with}`.
* Indicate 'true' as code-like.
@frewsxcv

frewsxcv commented Jan 19, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=GuillaumeGomez rollup

@bors

bors commented Jan 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c8822da has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 19, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#39165- frewsxcv:slice, r=GuillaumeGomez
3946079
A few improvements to the slice docs.
* Simplify `Option::iter_mut` doc example.
* Document 'empty' corner-cases for `slice::{starts_with, ends_with}`.
* Indicate 'true' as code-like.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 19, 2017
Merged
bors added a commit that referenced this pull request Jan 19, 2017
@bors
Auto merge of#39180- GuillaumeGomez:rollup, r=GuillaumeGomez
47965f5
Rollup of 11 pull requests
- Successful merges: #38457, #38922, #38970, #39039, #39091, #39115, #39121, #39149, #39150, #39151, #39165
- Failed merges:
@bors
bors merged commit c8822da into rust-lang:masterJan 19, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frewsxcv@rust-highfive@bors@BurntSushi