Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #39180
Merged
Merged
Conversation
for the new SliceIndex trait. Also made the docs of the unchecked versions a bit clearer; they return a reference, not an "unsafe pointer".
References to empty types are only considered empty if feature(never_type) is enabled.
* Simplify `Option::iter_mut` doc example.
* Document 'empty' corner-cases for `slice::{starts_with, ends_with}`.
* Indicate 'true' as code-like.Improvements to 'include' macro documentation. None
…r=steveklabnik Fix a couple of bad Markdown links
Deprecate `#[unsafe_destructor_blind_to_params]` CC rust-lang#34761 r? @pnkfelix
…, r=nrc debuginfo: Ignore optimized enum tests for GDB versions that can't handle them. Fixesrust-lang#38948. r? @nrc cc @Manishearth
…on, r=GuillaumeGomez Add error explanation for E0491 Refs rust-lang#32777 Please let me know if any question or anything doesn't look right about this.
consistent doc wording
minor typo fix None
…nds-where-clause, r=arielb1 E0122 should apply with where clauses Fixesrust-lang#39122
collections: update docs of slice get() and friends Resubmit of rust-lang#38216. r? @GuillaumeGomez BTW, instead of closing a PR just because it is old and the team member who offered to fix it up did not have the time to do so, why not ping them instead? (cc @alexcrichton)
…eferences, r=brson Feature gate `&Void`'s uninhabitedness. Here's a totally crazy PR which should never be merged.
A few improvements to the slice docs.
* Simplify `Option::iter_mut` doc example.
* Document 'empty' corner-cases for `slice::{starts_with, ends_with}`.
* Indicate 'true' as code-like.rust-highfive
commented
Jan 19, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Jan 19, 2017
MemberAuthor
@bors: r+ p=1 |
bors
commented
Jan 19, 2017
Collaborator
📌 Commit 3946079 has been approved by |
bors
commented
Jan 19, 2017
Collaborator
⌛ Testing commit 3946079 with merge 47965f5... |
bors
commented
Jan 19, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[unsafe_destructor_blind_to_params]#38970, debuginfo: Ignore optimized enum tests for GDB versions that can't handle them. #39039, Add error explanation for E0491 #39091, consistent doc wording #39115, minor typo fix #39121, E0122 should apply with where clauses #39149, collections: update docs of slice get() and friends #39150, Feature gate&Void's uninhabitedness. #39151, A few improvements to the slice docs. #39165