Skip to content

Add more docs for CoerceUnsized and Unsize - #38816

Merged
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:coercion-doc
Jan 10, 2017
Merged

Add more docs for CoerceUnsized and Unsize#38816
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:coercion-doc

Conversation

@Manishearth

@ManishearthManishearth commented Jan 4, 2017•
edited
Loading

Copy link
Copy Markdown
Member

here be dragons

r? @ubsan@steveklabnik

strega-nil
strega-nil reviewed Jan 4, 2017
View reviewed changes

@strega-nilstrega-nil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on the technical aspects, otherwise.

Comment threadsrc/libcore/marker.rs Outdated

@strega-nilstrega-nilJan 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be T is Unsize<Trait> when T: Trait, in order to be consistent with the above sentence.

Comment threadsrc/libcore/ops.rs Outdated

@strega-nilstrega-nilJan 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For builtin types" sounds unclear; perhaps reword this to say something to the effect of "for builtin pointer types".

Comment threadsrc/libcore/ops.rs Outdated

@strega-nilstrega-nilJan 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit; where U: ?Sized is, afaik, not valid syntax. Another argument for supporting it?

@ManishearthManishearthJan 4, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The docs also output this form. There is no reason not to support it IMO.

@Manishearth

Manishearth commented Jan 4, 2017

Copy link
Copy Markdown
MemberAuthor

Updated.

@GuillaumeGomez

GuillaumeGomez commented Jan 4, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Jan 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 07e844f has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#38816- Manishearth:coercion-doc, r=Guillau…
05913bd
…meGomez
Add more docs for CoerceUnsized and Unsize
here be dragons
r? @ubsan@steveklabnik
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 4, 2017
Closed
@steveklabniksteveklabnik mentioned this pull request Jan 4, 2017
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 4, 2017
@steveklabnik
Rollup merge ofrust-lang#38816- Manishearth:coercion-doc, r=Guillau…
6316e43
…meGomez
Add more docs for CoerceUnsized and Unsize
here be dragons
r? @ubsan@steveklabnik
@nrc

nrc commented Jan 5, 2017

Copy link
Copy Markdown
Member

cc @rust-lang/lang to make sure the docs fit our beliefs

@frewsxcvfrewsxcv mentioned this pull request Jan 9, 2017
Closed
@nikomatsakisnikomatsakis self-assigned this Jan 9, 2017
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jan 10, 2017
@sanxiyn
Rollup merge ofrust-lang#38816- Manishearth:coercion-doc, r=Guillau…
ac27238
…meGomez
Add more docs for CoerceUnsized and Unsize
here be dragons
r? @ubsan@steveklabnik
@sanxiynsanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of#38958- sanxiyn:rollup, r=sanxiyn
7bffede
Rollup of 11 pull requests
- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors
bors merged commit 07e844f into rust-lang:masterJan 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@strega-nilstrega-nilstrega-nil left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Manishearth@GuillaumeGomez@bors@nrc@strega-nil@nikomatsakis