Skip to content

Fix docs for TcpListener example. - #38845

Closed
ShaunKarran wants to merge 1 commit into
rust-lang:masterfrom
ShaunKarran:fix-tcplistener-doc
Closed

Fix docs for TcpListener example.#38845
ShaunKarran wants to merge 1 commit into
rust-lang:masterfrom
ShaunKarran:fix-tcplistener-doc

Conversation

@ShaunKarran

@ShaunKarranShaunKarran commented Jan 5, 2017

Copy link
Copy Markdown

No description provided.

@rust-highfive

rust-highfive commented Jan 5, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez

GuillaumeGomez commented Jan 5, 2017

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Jan 5, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit ec9adcc has been approved by GuillaumeGomez

@frewsxcvfrewsxcv mentioned this pull request Jan 9, 2017
Closed
@sanxiynsanxiyn mentioned this pull request Jan 10, 2017
Merged
bors added a commit that referenced this pull request Jan 10, 2017
@bors
Auto merge of#38958- sanxiyn:rollup, r=sanxiyn
7bffede
Rollup of 11 pull requests
- Successful merges: #38606, #38607, #38623, #38664, #38799, #38816, #38836, #38839, #38841, #38849, #38874
- Failed merges: #38845
@bors

bors commented Jan 10, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #38958) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn

sanxiyn commented Jan 11, 2017

Copy link
Copy Markdown
Contributor

Another person made the same change, which got merged first, see #38799. I am sorry about that.

@sanxiynsanxiyn closed this Jan 11, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sfacklersfackler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ShaunKarran@rust-highfive@GuillaumeGomez@bors@sanxiyn@sfackler