Uh oh!
There was an error while loading. Please reload this page.
Add note for E0117 - #39306
Merged
Merged
Conversation
rust-highfive
commented
Jan 25, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Jan 25, 2017
Contributor
Could you add a test? r=me otherwise @bors rollup |
GuillaumeGomezforce-pushed
the
newtype_help
branch
from
January 26, 2017 00:34
88557e8 to
1769f80CompareGuillaumeGomez
commented
Jan 26, 2017
MemberAuthor
Sorry forgot to add them. Updated. @bors r=eddyb rollup |
bors
commented
Jan 26, 2017
Collaborator
📌 Commit 1769f80 has been approved by |
durka
commented
Jan 26, 2017
Contributor
Travis failure looks real. I guess the order of the notes matters? |
GuillaumeGomezforce-pushed
the
newtype_help
branch
from
January 26, 2017 11:09
1769f80 to
eaf182eCompareGuillaumeGomez
commented
Jan 26, 2017
MemberAuthor
bors
commented
Jan 26, 2017
Collaborator
📌 Commit eaf182e has been approved by |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 28, 2017
Add note for E0117 Fixesrust-lang#39249. I just applied the suggestion of @durka since I don't see anything else to add.
bors added a commit
that referenced
this pull request
Jan 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#39249.
I just applied the suggestion of @durka since I don't see anything else to add.