Refactor stdlib for pal by cassiersg · Pull Request #39325 · rust-lang/rust

cassiersg · 2017-01-26T21:18:56Z

This is a small step towards pal. I moved all platform-specific code from libstd/{path,f32,f64}.rs to libstd/sys.
For the float implementation, I moved only the parts that are currently platform-specific, which leaves direct dependency on libc in libstd/f32.rs and libstd/f64.rs. I don't know if it is better to move all the dependency to libc in sys.

This removes one exception in the tidy lint 'pal'.

This removes exceptions in the tidy lint 'pal'.

rust-highfive · 2017-01-26T21:19:10Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2017-01-26T22:11:00Z

r? @brson

brson · 2017-01-26T22:12:54Z

@bors r+ beautiful thanks @cassiersg !

bors · 2017-01-26T22:12:55Z

📌 Commit 662fef6 has been approved by brson

brson · 2017-01-26T22:13:39Z

@bors r-

brson · 2017-01-26T22:15:43Z

@cassiersg the float commit looks incomplete to me - it adds the sys definitions but does not rewrite the float modules to use the sys/float modules. I'd expect std/f32 and std/f64 to change and for those files to be removed from the pal whitelist. Can you add another commit to do that?

Also remove exceptions in tidy lint 'pal'.

cassiersg · 2017-01-26T22:50:50Z

@brson I actually forgot to commit some files. Everything should be there now.

brson · 2017-01-27T00:28:28Z

@bors r+

Thanks @cassiersg. As a follow up to this (or in this PR if you want), even the common C functions need to be moved into 'sys' - a platform-independent std is ultimately not allowed to call C directly. Duplication of the C declarations is fine.

bors · 2017-01-27T00:28:29Z

📌 Commit badd513 has been approved by brson

bors · 2017-01-27T00:29:11Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Point to immutable arg/fields when trying to use as &mut #39139

bors · 2017-01-27T00:29:11Z

📌 Commit badd513 has been approved by brson

alexcrichton · 2017-01-27T23:35:53Z

I'm getting some failures on the rollup (#39353) on 64-bit MSVC:

 Doc-tests std
running 2 tests
thread 'rustc' panicked at 'test executable failed:
thread 'main' panicked at 'assertion failed: abs_difference <= f32::EPSILON', <anon>:12
note: Run with `RUST_BACKTRACE=1` for a backtrace.
', src\librustdoc\test.rs:305
note: Run with `RUST_BACKTRACE=1` for a backtrace.
test f32::f32::hypot_0 ... FAILED
test f64::f64::hypot_0 ... ok
failures:
failures:
f32::f32::hypot_0
test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured
error: test failed

I think those may be related to this PR? (haven't dug deeply though)

Rollup of 21 pull requests - Successful merges: #38617, #39284, #39285, #39290, #39302, #39305, #39306, #39307, #39311, #39313, #39314, #39321, #39325, #39332, #39335, #39344, #39345, #39346, #39348, #39350, #39351 - Failed merges:

bors · 2017-01-28T08:48:58Z

⌛ Testing commit badd513 with merge 1881594...

bors · 2017-01-28T09:41:37Z

💔 Test failed - status-appveyor

brson · 2017-02-07T23:41:09Z

@cassiersg Can you peek at the errors here?

cassiersg · 2017-02-08T07:57:51Z

@brson I don't have currently access to a windows system. I'll look at this next weekend.

ghost · 2017-02-10T23:08:45Z

+ #[cfg_attr(target_env = "msvc", link_name = "__lgamma_r")]
+ pub fn lgammaf_r(n: c_float, sign: &mut c_int) -> c_float;
+
+ #[cfg_attr(target_env = "msvc", link_name = "_hypot")]


I think the link_names here should be __lgammaf_r and _hypotf.
Since the test failed on f32::hypot_0 could this have caused the failure?

cassiersg · 2017-02-12T22:46:07Z

@brson I have not yet access to a windows environment. I just pushed a fix for the bug @whataloadofwhat found, since it is probably the cause of test failure.

alexcrichton · 2017-02-14T00:41:58Z

@bors: r=brson

bors · 2017-02-14T00:41:59Z

📌 Commit 7298535 has been approved by brson

Refactor stdlib for pal This is a small step towards [pal](https://internals.rust-lang.org/t/refactoring-std-for-ultimate-portability/4301/40). I moved all platform-specific code from `libstd/{path,f32,f64}.rs` to `libstd/sys`. For the float implementation, I moved only the parts that are currently platform-specific, which leaves direct dependency on libc in `libstd/f32.rs` and `libstd/f64.rs`. I don't know if it is better to move all the dependency to libc in `sys`.

bors · 2017-02-14T10:36:14Z

⌛ Testing commit 7298535 with merge ad597e7...

bors · 2017-02-14T12:36:56Z

💔 Test failed - status-travis

brson · 2017-03-09T00:58:52Z

Errors are legit @cassiersg.

alexcrichton · 2017-03-14T21:30:01Z

Closing due to inactivity, but feel free to resubmit with tests fixed!

cassiersg added 2 commits January 26, 2017 21:22

Move platform-specific implementation of libstd/path.rs
5b8fe3e
This removes one exception in the tidy lint 'pal'.

Move platform-specific implementation of libstd/f{32,64}.rs
662fef6
This removes exceptions in the tidy lint 'pal'.

rust-highfive assigned alexcrichton Jan 26, 2017

rust-highfive assigned brson and unassigned alexcrichton Jan 26, 2017

Use platform-specific implementation for floats
badd513
Also remove exceptions in tidy lint 'pal'.

alexcrichton mentioned this pull request Jan 27, 2017
Rollup of 21 pull requests #39353
Merged

ghost reviewed Feb 10, 2017
View reviewed changes

Fix wrong link names on windows
7298535

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 13, 2017

frewsxcv mentioned this pull request Feb 14, 2017
Rollup of 10 pull requests #39800
Closed

frewsxcv mentioned this pull request Feb 14, 2017
Rollup of 9 pull requests #39805
Closed

alexcrichton closed this Mar 14, 2017

Uh oh!

Uh oh!

Conversation

cassiersg commented Jan 26, 2017

Uh oh!

rust-highfive commented Jan 26, 2017

Uh oh!

alexcrichton commented Jan 26, 2017

Uh oh!

brson commented Jan 26, 2017

Uh oh!

bors commented Jan 26, 2017

Uh oh!

brson commented Jan 26, 2017

Uh oh!

brson commented Jan 26, 2017

Uh oh!

cassiersg commented Jan 26, 2017

Uh oh!

brson commented Jan 27, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jan 27, 2017

Uh oh!

bors commented Jan 27, 2017

Uh oh!

bors commented Jan 27, 2017

Uh oh!

alexcrichton commented Jan 27, 2017

Uh oh!

bors commented Jan 28, 2017

Uh oh!

bors commented Jan 28, 2017

Uh oh!

brson commented Feb 7, 2017

Uh oh!

cassiersg commented Feb 8, 2017

Uh oh!

ghostFeb 10, 2017

Choose a reason for hiding this comment

Uh oh!

cassiersg commented Feb 12, 2017

Uh oh!

alexcrichton commented Feb 14, 2017

Uh oh!

bors commented Feb 14, 2017

Uh oh!

bors commented Feb 14, 2017

Uh oh!

bors commented Feb 14, 2017

Uh oh!

brson commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brson commented Jan 27, 2017•
edited
Loading