Uh oh!
There was an error while loading. Please reload this page.
Fix up @carols10cents' mailmap entry - #39345
Conversation
The previous ways didn't work; this does. cc rust-lang-nursery/thanks#45
rust-highfive
commented
Jan 27, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Jan 27, 2017
@bors: r+ |
bors
commented
Jan 27, 2017
📌 Commit 0f2a5f6 has been approved by |
est31
commented
Jan 27, 2017
I don't think this will work. According to the manual page one person should always have one line, with the preffered name and email at the start, and any other (or previous) names and emails following in the same line. Also, if somebody used the same email but a different name, it counts as different person, so it needs to be inside the line as well. Deleting a name from the mailmap won't help, as the name is still mentioned in the git history of rustc. |
est31
commented
Jan 27, 2017
Mhh, testing |
steveklabnik
commented
Jan 27, 2017
I checked this locally; before this change, both her names are in there, afterwards, there's only one. I share your confusion about the man page. |
…richton Fix up @carols10cents' mailmap entry The previous ways didn't work; this does. cc rust-lang-nursery/thanks#45
frewsxcv
commented
Jan 28, 2017
@bors rollup |
The previous ways didn't work; this does.
cc rust-lang-nursery/thanks#45