Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Show attributes on all item types - #39654
Merged
Merged
Conversation
Currently attributes are only shown for structs, unions and enums but they should be shown for all items. For example it is useful to know if a function is `#[no_mangle]`.
rust-highfive
commented
Feb 8, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Feb 12, 2017
Member
Do you have a generated doc which displays the change please? |
ollie27
commented
Feb 12, 2017
ContributorAuthor
https://ollie27.github.io/rust_doc_test/std/index.html has this change applied. The only change to the I assume you wanted these attributes displayed as you listed them in #37134. |
GuillaumeGomez
commented
Feb 12, 2017
Member
Oh nice! Thanks a lot! :) @bors: r+ rollup |
bors
commented
Feb 12, 2017
Collaborator
📌 Commit 147d173 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 12, 2017
…aumeGomez rustdoc: Show attributes on all item types Currently attributes are only shown for structs, unions and enums but they should be shown for all items. For example it is useful to know if a function is `#[no_mangle]`.
bors added a commit
that referenced
this pull request
Feb 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently attributes are only shown for structs, unions and enums but
they should be shown for all items. For example it is useful to know if a
function is
#[no_mangle].