Skip to content

Fixes #39661 - #39662

Merged
bors merged 2 commits into
rust-lang:masterfrom
Henning-K:patch-1
Feb 12, 2017
Merged

Fixes #39661#39662
bors merged 2 commits into
rust-lang:masterfrom
Henning-K:patch-1

Conversation

@Henning-K

@Henning-KHenning-K commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Clarifies the potential ambiguity.

@Henning-K
Fixedrust-lang#39661
51ef003
Clarified potential ambiguity.
@rust-highfive

rust-highfive commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Looks great! Thank you so much!

@bors: r+ rollup

@bors

bors commented Feb 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 51ef003 has been approved by steveklabnik

@euclio

euclio commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Hm, I think there should be an article before "map".

@Henning-K

Henning-K commented Feb 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@euclio Ah, missed that. How about "a"?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 9, 2017
@frewsxcv
Rollup merge ofrust-lang#39662- Henning-K:patch-1, r=steveklabnik
14d894f
Fixesrust-lang#39661
Clarifies the potential ambiguity.
@frewsxcvfrewsxcv mentioned this pull request Feb 9, 2017
Closed
@frewsxcv

frewsxcv commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

Looks good, thanks for your contribution!

@bors r+ rollup

@bors

bors commented Feb 12, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 8251a2d has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 12, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#39662- Henning-K:patch-1, r=frewsxcv
747b9e5
Fixesrust-lang#39661
Clarifies the potential ambiguity.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Feb 12, 2017
Merged
bors added a commit that referenced this pull request Feb 12, 2017
@bors
Auto merge of#39769- GuillaumeGomez:rollup, r=GuillaumeGomez
81bd267
Rollup of 7 pull requests
- Successful merges: #39654, #39662, #39697, #39740, #39743, #39756, #39760
- Failed merges:
@bors
bors merged commit 8251a2d into rust-lang:masterFeb 12, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Henning-K@rust-highfive@steveklabnik@bors@euclio@frewsxcv@BurntSushi