Uh oh!
There was an error while loading. Please reload this page.
Add the item type to the tooltip - #39697
Conversation
rust-highfive
commented
Feb 9, 2017
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
QuietMisdreavus
commented
Feb 9, 2017
Nice! Would it be possible to render the docs with this and get a couple screenshots with the new tooltips? |
notriddle
commented
Feb 9, 2017
notriddle
commented
Feb 9, 2017
QuietMisdreavus
commented
Feb 9, 2017
Thanks! That one with |
GuillaumeGomez
commented
Feb 12, 2017
Thanks a lot for this. Since everyone seems to agree on the improvement here, let's merge! @bors: r+ rollup |
bors
commented
Feb 12, 2017
📌 Commit bc4ad1a has been approved by |
…umeGomez Add the item type to the tooltip See: https://users.rust-lang.org/t/seeking-opinions-from-colorblind-rustaceans-coloring-in-rustdoc-code-blocks
…-tooltips, r=GuillaumeGomez rustdoc: add more tooltips to intra-doc links This commit makes intra-doc link tooltips consistent with generated links in function signatures and item tables, with the format `itemtype foo::bar::baz`. This way, you can tell if a link points at a trait or a type (for example) by mousing over it. See also rust-lang#39697 Partially solves https://internals.rust-lang.org/t/rustdoc-suggestion-highlight-links-fn-s-mod-s-type-s-etc-appropriately-within-and-documentation/17931 (though the Internals thread asks for color-coding, while this PR adds a tooltip instead, it's accomplishing the same thing). Before: <img width="950" alt="image" src="https://user-images.githubusercontent.com/1593513/218653059-911cea01-7231-438a-ad98-be98ab73783f.png"> After: <img width="432" alt="image" src="https://user-images.githubusercontent.com/1593513/218653201-34ca3aa7-18f1-4cb1-be68-a1411bbe797e.png">






See:
https://users.rust-lang.org/t/seeking-opinions-from-colorblind-rustaceans-coloring-in-rustdoc-code-blocks