Uh oh!
There was an error while loading. Please reload this page.
[rustbuild] add a way to run command after failure - #39888
Merged
Conversation
rust-highfive
commented
Feb 16, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
MemberAuthor
This is what it looks in practice: |
nikomatsakis
commented
Feb 16, 2017
Contributor
Hmm this definitely seems to fill a need for me! |
This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can’t just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres’s multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that’s left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
nagisaforce-pushed
the
on-fail-bootstrap
branch
from
February 16, 2017 19:12
b244821 to
0e45a5eComparenagisa
commented
Feb 16, 2017
MemberAuthor
r? @alexcrichton is probably the most suitable reviewer |
alexcrichton
commented
Feb 16, 2017
Member
Oh man, that's slick! Awesome idea! @bors: r+ |
bors
commented
Feb 16, 2017
Collaborator
📌 Commit 0e45a5e has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
…chton [rustbuild] add a way to run command after failure This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can’t just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres’s multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that’s left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
…chton [rustbuild] add a way to run command after failure This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can’t just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres’s multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that’s left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
alexcrichton
commented
Feb 19, 2017
Member
@bors: retry |
1 similar comment
alexcrichton
commented
Feb 19, 2017
Member
@bors: retry |
bors
commented
Feb 19, 2017
Collaborator
⌛ Testing commit 0e45a5e with merge f0fb8e4... |
bors
commented
Feb 19, 2017
Collaborator
💔 Test failed - status-travis |
nagisa
commented
Feb 19, 2017
MemberAuthor
|
alexcrichton
commented
Feb 21, 2017
via email
Member
@bors: retry
* network error …On Sun, Feb 19, 2017 at 4:31 AM, Simonas Kazlauskas < ***@***.***> wrote:
[image: Build Failed; Again]
<https://cloud.githubusercontent.com/assets/679122/23101567/47e65f76-f69f-11e6-81de-6c025928e31e.jpeg>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#39888 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Izj-Sy5oJ6pSIRvupvr3LcHmtDaks5reBoFgaJpZM4MDafL>
.
|
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 23, 2017
…chton [rustbuild] add a way to run command after failure This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can't just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres's multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that's left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
bors
commented
Feb 24, 2017
Collaborator
⌛ Testing commit 0e45a5e with merge e15ee81... |
bors
commented
Feb 24, 2017
Collaborator
💔 Test failed - status-travis |
nagisa
commented
Feb 24, 2017
MemberAuthor
|
alexcrichton
commented
Feb 25, 2017
Member
@bors: retry
|
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
…chton [rustbuild] add a way to run command after failure This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can't just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres's multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that's left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
…chton [rustbuild] add a way to run command after failure This is a simple way to workaround the debugging issues caused by the rustc wrapper used in the bootstrap process. Namely, it uses some obscure environment variables and you can't just copy the failed command and run it in the shell or debugger to examine the failure more closely. With `--on-fail` its possible to run an arbitrary command within exactly the same environment under which rustc failed. Theres's multiple ways to use this new flag: $ python x.py build --stage=1 --on-fail=env would print a list of environment variables and the failed command, so a few copy-pastes and you now can run the same rust in your shell outside the bootstrap system. $ python x.py build --stage=1 --on-fail=bash Is a more useful variation of the command above in that it launches a whole shell with environment already in place! All that's left to do is copy-paste the command just above the shell prompt! Fixesrust-lang#38686Fixesrust-lang#38221
bors added a commit
that referenced
this pull request
Feb 25, 2017
Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple way to workaround the debugging issues caused by the rustc
wrapper used in the bootstrap process. Namely, it uses some obscure environment
variables and you can't just copy the failed command and run it in the shell or
debugger to examine the failure more closely.
With
--on-failits possible to run an arbitrary command within exactly thesame environment under which rustc failed. Theres's multiple ways to use this
new flag:
$ python x.py build --stage=1 --on-fail=env
$ python x.py build --stage=1 --on-fail=bash
Fixes#38686
Fixes#38221