Uh oh!
There was an error while loading. Please reload this page.
travis: Compile a more compatible libc.a for musl - #40019
Merged
Conversation
The mitigations for rust-lang#34978 involve passing `-Wa,-mrelax-relocations=no` to all C code we compile, and we just forgot to pass it when compiling musl itself. Closesrust-lang#39979
This doesn't belong in rustbuild itself, and now that we have only rustbuild we can move this out of the build system.
rust-highfive
commented
Feb 21, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Feb 21, 2017
Contributor
@bors r+ |
bors
commented
Feb 21, 2017
Collaborator
📌 Commit 9a08f40 has been approved by |
nikomatsakis
commented
Feb 22, 2017
Contributor
r? @brson |
BurntSushi
commented
Feb 24, 2017
Member
@alexcrichton Did this make it into the |
alexcrichton
commented
Feb 24, 2017
MemberAuthor
@BurntSushi this PR hasn't landed yet? |
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
travis: Compile a more compatible libc.a for musl The mitigations for rust-lang#34978 involve passing `-Wa,-mrelax-relocations=no` to all C code we compile, and we just forgot to pass it when compiling musl itself. Closesrust-lang#39979
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
travis: Compile a more compatible libc.a for musl The mitigations for rust-lang#34978 involve passing `-Wa,-mrelax-relocations=no` to all C code we compile, and we just forgot to pass it when compiling musl itself. Closesrust-lang#39979
bors added a commit
that referenced
this pull request
Feb 25, 2017
Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mitigations for #34978 involve passing
-Wa,-mrelax-relocations=noto all Ccode we compile, and we just forgot to pass it when compiling musl itself.
Closes#39979