Skip to content

Adds rust-windbg.cmd script - #39983

Merged
bors merged 1 commit into
rust-lang:masterfrom
AndrewGaspar:rust-windbg
Apr 26, 2017
Merged

Adds rust-windbg.cmd script#39983
bors merged 1 commit into
rust-lang:masterfrom
AndrewGaspar:rust-windbg

Conversation

@AndrewGaspar

@AndrewGasparAndrewGaspar commented Feb 20, 2017

Copy link
Copy Markdown
Contributor

Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.

This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.

Example usage from cmd or PowerShell:

rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe

@rust-highfive

rust-highfive commented Feb 20, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Feb 21, 2017

Copy link
Copy Markdown
Member

r? @brson

@AndrewGasparAndrewGaspar mentioned this pull request Mar 12, 2017
Merged
@alexcrichton

alexcrichton commented Apr 14, 2017

Copy link
Copy Markdown
Member

Sorry for the delay here @AndrewGaspar! I'll try to ping @brson in person soon to help move this along.

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2017
@alexcrichton

alexcrichton commented Apr 20, 2017

Copy link
Copy Markdown
Member

Haven't forgotten this, @brson will be back next week from China

@brson

brson commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9737ee2 has been approved by brson

@brsonbrson added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 24, 2017
@brson

brson commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

cc @vadimcn does this look reasonable to you?

@bors

bors commented Apr 24, 2017

Copy link
Copy Markdown
Collaborator

🔒 Merge conflict

@alexcrichton

alexcrichton commented Apr 24, 2017

Copy link
Copy Markdown
Member

@bors: r=brson

@bors

bors commented Apr 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 70e6739 has been approved by brson

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 70e6739 with merge 10f481d...

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 25, 2017
@frewsxcv
Rollup merge ofrust-lang#39983- AndrewGaspar:rust-windbg, r=brson
2ac3d6a
Adds rust-windbg.cmd script
Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.
This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.
Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@frewsxcvfrewsxcv mentioned this pull request Apr 25, 2017
Closed
@frewsxcv

frewsxcv commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

@bors retry prioritizing rollup

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

@bors: retry

@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#39983- AndrewGaspar:rust-windbg, r=brson
7a87593
Adds rust-windbg.cmd script
Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.
This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.
Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#39983- AndrewGaspar:rust-windbg, r=brson
c4db48c
Adds rust-windbg.cmd script
Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.
This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.
Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge ofrust-lang#39983- AndrewGaspar:rust-windbg, r=brson
27fbe8c
Adds rust-windbg.cmd script
Adds rust-gdb/rust-lldb equivalent for windbg that loads the Rust .natvis files on start.
This change modifies the bootstrap code to add rust-windbg to bin and the .natvis files to lib/rustlib/etc.
Example usage from cmd or PowerShell:
```
rust-windbg -c "bu rs_f442289d74765418!rs::main;g" target\debug\rs.exe
```
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of#41551- frewsxcv:rollup, r=frewsxcv
4512424
Rollup of 9 pull requests
- Successful merges: #39983, #41442, #41463, #41500, #41518, #41527, #41528, #41530, #41535
- Failed merges:
@bors
bors merged commit 70e6739 into rust-lang:masterApr 26, 2017
ehuss added a commit to ehuss/rust that referenced this pull request Jan 13, 2022
@ehuss
Remove duplicaterust-lang#39983. It was part of 1.19.
73cb56e
ehuss added a commit to ehuss/rust that referenced this pull request Jan 14, 2022
@ehuss
Remove duplicaterust-lang#39983. It was part of 1.19.
c1526c6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AndrewGaspar@rust-highfive@alexcrichton@brson@bors@frewsxcv@nikomatsakis@arielb1