Skip to content

Add internal accessor methods to io::{Chain, Take}. - #41463

Merged
bors merged 4 commits into
rust-lang:masterfrom
SergioBenitez:master
Apr 26, 2017
Merged

Add internal accessor methods to io::{Chain, Take}.#41463
bors merged 4 commits into
rust-lang:masterfrom
SergioBenitez:master

Conversation

@SergioBenitez

@SergioBenitezSergioBenitez commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

Resolves#29067.

@rust-highfive

rust-highfive commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SergioBenitez

SergioBenitez commented Apr 22, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @aturon

@SergioBenitez
SergioBenitezforce-pushed the master branch 3 times, most recently from 76df370 to daa74f7CompareApril 22, 2017 10:36
@frewsxcvfrewsxcv added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api [DEPRECATED; DO NOT USE] labels Apr 22, 2017
@bors

bors commented Apr 23, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #41437) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton

alexcrichton commented Apr 24, 2017

Copy link
Copy Markdown
Member

Looks good to me, thanks!

Could you also be sure to document on the get_mut case that care should be taken to not corrupt the stream? (e.g. doing your own reads/writes may mess up the internal state of these structs).

Other than r=me. Can you file a tracking issue and cc me? I'll be sure to tag it appropriately

@SergioBenitezSergioBenitez mentioned this pull request Apr 24, 2017
Closed
@SergioBenitez

SergioBenitez commented Apr 24, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Awesome, thanks @alexcrichton!

@aturon

aturon commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

@bors: r=alexcrichton

(Need r+ rights for this).

@bors

bors commented Apr 24, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit f0fcbff has been approved by alexcrichton

@SergioBenitez

SergioBenitez commented Apr 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Ah, that makes sense. :) Thanks!

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

@bors: r-

oh looks like some of the issue references are still ="0"? though?

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

oops didn't mean to close

@SergioBenitez

SergioBenitez commented Apr 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Ah, of course! Did indeed forget those. They're in now.

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c168d8b has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 25, 2017
@frewsxcv
Rollup merge ofrust-lang#41463- SergioBenitez:master, r=alexcrichton
4318c48
Add internal accessor methods to io::{Chain, Take}.
Resolvesrust-lang#29067.
@frewsxcvfrewsxcv mentioned this pull request Apr 25, 2017
Closed
@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41463- SergioBenitez:master, r=alexcrichton
aee29a7
Add internal accessor methods to io::{Chain, Take}.
Resolvesrust-lang#29067.
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41463- SergioBenitez:master, r=alexcrichton
9e6641a
Add internal accessor methods to io::{Chain, Take}.
Resolvesrust-lang#29067.
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge ofrust-lang#41463- SergioBenitez:master, r=alexcrichton
5f62b27
Add internal accessor methods to io::{Chain, Take}.
Resolvesrust-lang#29067.
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of#41551- frewsxcv:rollup, r=frewsxcv
4512424
Rollup of 9 pull requests
- Successful merges: #39983, #41442, #41463, #41500, #41518, #41527, #41528, #41530, #41535
- Failed merges:
@bors
bors merged commit c168d8b into rust-lang:masterApr 26, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SergioBenitez@rust-highfive@bors@alexcrichton@aturon@frewsxcv@arielb1