Skip to content

Made no_stack_check a stable_removed attribute - #40110

Merged
bors merged 2 commits into
rust-lang:masterfrom
benschreiber:nostackcheck
Mar 2, 2017
Merged

Made no_stack_check a stable_removed attribute#40110
bors merged 2 commits into
rust-lang:masterfrom
benschreiber:nostackcheck

Conversation

@benschreiber

@benschreiberbenschreiber commented Feb 26, 2017

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson

brson commented Feb 26, 2017

Copy link
Copy Markdown
Contributor

@bors r+ Thanks @benschreiber !

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9c5e4af has been approved by brson

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9c5e4af with merge 1046c25...

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Feb 26, 2017 via email

Copy link
Copy Markdown
Member

@alexcrichton

alexcrichton commented Feb 28, 2017

Copy link
Copy Markdown
Member

@bors: r=brson

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: travis: Split Android into dist/test images #40135

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9c5e4af has been approved by brson

@alexcrichton

alexcrichton commented Feb 28, 2017

Copy link
Copy Markdown
Member

@bors: retry

@eddybeddyb mentioned this pull request Feb 28, 2017
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Feb 28, 2017
@eddyb
Rollup merge ofrust-lang#40110- benschreiber:nostackcheck, r=brson
4fdeeb7
Made no_stack_check a stable_removed attribute
r? @brson
@eddybeddyb mentioned this pull request Feb 28, 2017
Closed
@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9c5e4af with merge 6f927d0...

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Feb 28, 2017 via email

Copy link
Copy Markdown
Member

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
@frewsxcv
Rollup merge ofrust-lang#40110- benschreiber:nostackcheck, r=brson
aef07cd
Made no_stack_check a stable_removed attribute
r? @brson
@frewsxcvfrewsxcv mentioned this pull request Mar 2, 2017
Merged
bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of#40216- frewsxcv:rollup, r=frewsxcv
c0b7112
Rollup of 7 pull requests
- Successful merges: #39832, #40104, #40110, #40117, #40129, #40139, #40166
- Failed merges:
@bors
bors merged commit 9c5e4af into rust-lang:masterMar 2, 2017
@benschreiber
benschreiber deleted the nostackcheck branch March 2, 2017 23:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benschreiber@rust-highfive@brson@bors@alexcrichton