Skip to content

std::process for fuchsia: updated to latest liblaunchpad - #40139

Merged
bors merged 1 commit into
rust-lang:masterfrom
tedsta:fuchsia_std_process_fix
Mar 2, 2017
Merged

std::process for fuchsia: updated to latest liblaunchpad#40139
bors merged 1 commit into
rust-lang:masterfrom
tedsta:fuchsia_std_process_fix

Conversation

@tedsta

@tedstatedsta commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

Our liblaunchpad changed a bit and so fuchsia's std::process impl needs to change a bit.

@raphlinus

@rust-highfive

rust-highfive commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

raphlinus
raphlinus reviewed Feb 28, 2017
View reviewed changes
Comment threadsrc/libstd/sys/unix/process/process_fuchsia.rs Outdated

@raphlinusraphlinusFeb 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here?

@tedstatedstaFeb 28, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch

@raphlinus

raphlinus commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

This looks good to me, on reading the code. I'll build locally as well, just to make sure.

raphlinus
raphlinus reviewed Feb 28, 2017
View reviewed changes
Comment threadsrc/libstd/sys/unix/process/process_fuchsia.rs Outdated

@raphlinusraphlinusFeb 28, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "tidy" linter didn't like this. It feels like a TODO to me, but if it wants FIXME, I suppose we should make it happy.

@alexcrichton

alexcrichton commented Feb 28, 2017

Copy link
Copy Markdown
Member

Looks great, thanks! r=me with the tidy failure fixed

@raphlinus

raphlinus commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

Confirm that Rust is functional again, xi editor builds and runs. I haven't deeply exercised process creation though.

@tedsta
tedstaforce-pushed the fuchsia_std_process_fix branch from e994eaf to a198b41CompareFebruary 28, 2017 18:26
@tedsta
tedstaforce-pushed the fuchsia_std_process_fix branch from a198b41 to 2123d6aCompareFebruary 28, 2017 18:28
@tedsta

tedsta commented Feb 28, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=alexcrichton tidy fixed

@raphlinus yeah I plan to write a bunch of unit tests for sys/fuchsia to give us some peace of mind.

@alexcrichton

alexcrichton commented Feb 28, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Feb 28, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 2123d6a has been approved by alexcrichton

@tedsta

tedsta commented Mar 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Looks like some tests failed because of S3 outage yesterday. Is there a way I can trigger a rerun?

@alexcrichton

alexcrichton commented Mar 1, 2017

Copy link
Copy Markdown
Member

@tedsta oh this PR is in the queue which is the one that really matters, the Travis status on the PR itself is mostly just advisory currently

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
@frewsxcv
Rollup merge ofrust-lang#40139- tedsta:fuchsia_std_process_fix, r=a…
cedc0d2
…lexcrichton
std::process for fuchsia: updated to latest liblaunchpad
Our liblaunchpad changed a bit and so fuchsia's std::process impl needs to change a bit.
@raphlinus
@frewsxcvfrewsxcv mentioned this pull request Mar 2, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 2, 2017
@frewsxcv
Rollup merge ofrust-lang#40139- tedsta:fuchsia_std_process_fix, r=a…
05e0d74
…lexcrichton
std::process for fuchsia: updated to latest liblaunchpad
Our liblaunchpad changed a bit and so fuchsia's std::process impl needs to change a bit.
@raphlinus
@frewsxcvfrewsxcv mentioned this pull request Mar 2, 2017
Merged
bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of#40216- frewsxcv:rollup, r=frewsxcv
c0b7112
Rollup of 7 pull requests
- Successful merges: #39832, #40104, #40110, #40117, #40129, #40139, #40166
- Failed merges:
@bors
bors merged commit 2123d6a into rust-lang:masterMar 2, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@raphlinusraphlinusraphlinus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tedsta@rust-highfive@raphlinus@alexcrichton@bors