Uh oh!
There was an error while loading. Please reload this page.
Allow types passed to [] to coerce, like .index() - #40166
Merged
Conversation
rust-highfive
commented
Mar 1, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Mar 1, 2017
Contributor
Huh, did this change at some point? I remember it checking the expression somewhere nested so this wouldn't work. Based on what I see, this looks good. r? @nikomatsakis (in case I'm missing anything) |
nikomatsakis
commented
Mar 2, 2017
Contributor
seems ok to me, nice :) |
nikomatsakis
commented
Mar 2, 2017
Contributor
@bors r+ |
bors
commented
Mar 2, 2017
Collaborator
📌 Commit c58fff2 has been approved by |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 2, 2017
…tsakis Allow types passed to [] to coerce, like .index() Fixesrust-lang#40085 Basically steals the relevant part of [check_argument_types](https://github.com/rust-lang/rust/blob/1.15.1/src/librustc_typeck/check/mod.rs#L2653-L2672).
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 2, 2017
…tsakis Allow types passed to [] to coerce, like .index() Fixesrust-lang#40085 Basically steals the relevant part of [check_argument_types](https://github.com/rust-lang/rust/blob/1.15.1/src/librustc_typeck/check/mod.rs#L2653-L2672).
bors added a commit
that referenced
this pull request
Mar 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#40085
Basically steals the relevant part of check_argument_types.