Remove internal liblog by alexcrichton · Pull Request #40347 · rust-lang/rust

alexcrichton · 2017-03-08T04:43:21Z

This commit deletes the internal liblog in favor of the implementation that
lives on crates.io. Similarly it's also setting a convention for adding crates
to the compiler. The main restriction right now is that we want compiler
implementation details to be unreachable from normal Rust code (e.g. requires a
feature), and by default everything in the sysroot is reachable via extern crate.

The proposal here is to require that crates pulled in have these lines in their
src/lib.rs:

#![cfg_attr(rustbuild, feature(staged_api, rustc_private))]
#![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))]

This'll mean that by default they're not using these attributes but when
compiled as part of the compiler they do a few things:

Mark themselves as entirely unstable via the staged_api feature and the
#![unstable] attribute.
Allow usage of other unstable crates via feature(rustc_private) which is
required if the crate relies on any other crates to compile (other than std).

rust-highfive · 2017-03-08T04:43:26Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-03-08T04:47:08Z

r? @brson

Note that this is the first crates.io crate to be included in the compiler itself, but I believe that everything is ironed out!

Also note that we have a test if a crate is used and the annotations above are forgotten. We also have license checking for crates.io deps to get errors by default if were working with unusual licenses.

hanna-kruppe · 2017-03-08T12:57:15Z

I seem to recall that the behavior of debug! diverged between these two logging libraries: the internal version (the one being removed here) strips them if debug_assertions are disabled, while the crates.io version doesn't. Is this correct, and if so, are we okay with changing that?

alexcrichton · 2017-03-08T15:23:08Z

@rkruppe for the compiler I've now enabled the release_max_level_info which I believe should have the same effect.

alexcrichton · 2017-03-08T15:23:14Z

(good catch!)

brson · 2017-03-09T20:36:53Z

@bors r+

bors · 2017-03-09T20:36:55Z

📌 Commit 5f10bb5 has been approved by brson

alexcrichton · 2017-03-10T15:57:28Z

@bors: r-

this breaks a number of crates

steveklabnik · 2017-03-10T17:01:48Z

this breaks a number of crates

How did you determine this?

alexcrichton · 2017-03-10T17:30:40Z

Heh via wizardry :)

(the travis logs also indicate this)

I have suspicions for what's going on here and how to fix it, I don't have time to act on them just yet though.

bors · 2017-03-11T08:30:39Z

☔ The latest upstream changes (presumably #40432) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2017-03-16T20:48:12Z

@bors: r=brson

bors · 2017-03-16T20:48:12Z

📌 Commit a4bd5e9 has been approved by brson

Remove internal liblog This commit deletes the internal liblog in favor of the implementation that lives on crates.io. Similarly it's also setting a convention for adding crates to the compiler. The main restriction right now is that we want compiler implementation details to be unreachable from normal Rust code (e.g. requires a feature), and by default everything in the sysroot is reachable via `extern crate`. The proposal here is to require that crates pulled in have these lines in their `src/lib.rs`: #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))] This'll mean that by default they're not using these attributes but when compiled as part of the compiler they do a few things: * Mark themselves as entirely unstable via the `staged_api` feature and the `#![unstable]` attribute. * Allow usage of other unstable crates via `feature(rustc_private)` which is required if the crate relies on any other crates to compile (other than std).

frewsxcv · 2017-03-17T21:04:20Z

It looks like Travis hit an ICE. Is that related to these changes?

alexcrichton · 2017-03-17T21:05:32Z

No idea how, but my guess is yes :(

@bors: r-

alexcrichton · 2017-03-17T22:26:06Z

@bors: r+

@frewsxcv I wouldn't recommend rolling this up though...

bors · 2017-03-17T22:26:07Z

📌 Commit e4af5fd has been approved by alexcrichton

Remove internal liblog This commit deletes the internal liblog in favor of the implementation that lives on crates.io. Similarly it's also setting a convention for adding crates to the compiler. The main restriction right now is that we want compiler implementation details to be unreachable from normal Rust code (e.g. requires a feature), and by default everything in the sysroot is reachable via `extern crate`. The proposal here is to require that crates pulled in have these lines in their `src/lib.rs`: #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))] This'll mean that by default they're not using these attributes but when compiled as part of the compiler they do a few things: * Mark themselves as entirely unstable via the `staged_api` feature and the `#![unstable]` attribute. * Allow usage of other unstable crates via `feature(rustc_private)` which is required if the crate relies on any other crates to compile (other than std).

alexcrichton · 2017-03-23T18:29:11Z

@bors: r=brson

bors · 2017-03-23T18:29:12Z

📌 Commit e341d60 has been approved by brson

bors · 2017-03-24T13:13:24Z

⌛ Testing commit e341d60 with merge 4509a6e...

bors · 2017-03-24T14:10:10Z

💔 Test failed - status-travis

alexcrichton · 2017-03-24T14:48:40Z

@bors: retry * looks like an sccache timeout #40240

…

On Fri, Mar 24, 2017 at 9:10 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/214641032> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#40347 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95COiO5fGF0MSF_BVZlZZ3GDPGxMrks5ro87EgaJpZM4MWXFU> .

Remove internal liblog This commit deletes the internal liblog in favor of the implementation that lives on crates.io. Similarly it's also setting a convention for adding crates to the compiler. The main restriction right now is that we want compiler implementation details to be unreachable from normal Rust code (e.g. requires a feature), and by default everything in the sysroot is reachable via `extern crate`. The proposal here is to require that crates pulled in have these lines in their `src/lib.rs`: #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))] This'll mean that by default they're not using these attributes but when compiled as part of the compiler they do a few things: * Mark themselves as entirely unstable via the `staged_api` feature and the `#![unstable]` attribute. * Allow usage of other unstable crates via `feature(rustc_private)` which is required if the crate relies on any other crates to compile (other than std).

Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors · 2017-03-25T11:20:13Z

⌛ Testing commit e341d60 with merge 1ff1f1d...

bors · 2017-03-25T11:24:16Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T12:29:53Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-25T13:38:14Z

⌛ Testing commit e341d60 with merge 6b90ac4...

bors · 2017-03-25T13:44:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T14:39:15Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-25T15:50:16Z

⌛ Testing commit e341d60 with merge e092448...

bors · 2017-03-25T15:56:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-25T19:36:26Z

try to fix the build on emscripten #40821
@bors retry

bors · 2017-03-26T04:26:26Z

⌛ Testing commit e341d60 with merge 7dd4e2d...

Remove internal liblog This commit deletes the internal liblog in favor of the implementation that lives on crates.io. Similarly it's also setting a convention for adding crates to the compiler. The main restriction right now is that we want compiler implementation details to be unreachable from normal Rust code (e.g. requires a feature), and by default everything in the sysroot is reachable via `extern crate`. The proposal here is to require that crates pulled in have these lines in their `src/lib.rs`: #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] #![cfg_attr(rustbuild, unstable(feature = "rustc_private", issue = "27812"))] This'll mean that by default they're not using these attributes but when compiled as part of the compiler they do a few things: * Mark themselves as entirely unstable via the `staged_api` feature and the `#![unstable]` attribute. * Allow usage of other unstable crates via `feature(rustc_private)` which is required if the crate relies on any other crates to compile (other than std).

bors · 2017-03-26T08:09:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 7dd4e2d to master...

rust-highfive assigned arielb1 Mar 8, 2017

rust-highfive assigned brson and unassigned arielb1 Mar 8, 2017

alexcrichton force-pushed the rm-liblog branch from 11606a6 to 5f10bb5Compare March 8, 2017 15:22

alexcrichton mentioned this pull request Mar 10, 2017
Rollup of 36 pull requests #40418
Closed

alexcrichton mentioned this pull request Mar 14, 2017
Use crates.io version of rustc-serialize #40527
Closed

nrc mentioned this pull request Mar 15, 2017
Use rls-data crate #40554
Merged

alexcrichton force-pushed the rm-liblog branch from 5f10bb5 to a4bd5e9Compare March 16, 2017 20:47

frewsxcv mentioned this pull request Mar 17, 2017
Rollup of 15 pull requests #40615
Closed

alexcrichton force-pushed the rm-liblog branch from a4bd5e9 to e4af5fdCompare March 17, 2017 22:25

frewsxcv mentioned this pull request Mar 18, 2017
Rollup of 20 pull requests #40643
Closed

alexcrichton mentioned this pull request Mar 25, 2017
Rollup of 11 pull requests #40810
Closed

bors added a commit that referenced this pull request Mar 25, 2017
Auto merge of#40810- alexcrichton:rollup, r=alexcrichton
40ae49a
Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors added a commit that referenced this pull request Mar 25, 2017
Auto merge of#40810- alexcrichton:rollup, r=alexcrichton
ed9108d
Rollup of 11 pull requests - Successful merges: #40347, #40501, #40516, #40524, #40540, #40642, #40683, #40764, #40778, #40807, #40809 - Failed merges: #40771

bors merged commit e341d60 into rust-lang:masterMar 26, 2017

bors mentioned this pull request Mar 26, 2017
Improve InternedString usability #40606
Merged

alexcrichton deleted the rm-liblog branch April 4, 2017 23:08

Uh oh!

Uh oh!

Conversation

alexcrichton commented Mar 8, 2017

Uh oh!

rust-highfive commented Mar 8, 2017

Uh oh!

alexcrichton commented Mar 8, 2017

Uh oh!

hanna-kruppe commented Mar 8, 2017

Uh oh!

alexcrichton commented Mar 8, 2017

Uh oh!

alexcrichton commented Mar 8, 2017

Uh oh!

brson commented Mar 9, 2017

Uh oh!

bors commented Mar 9, 2017

Uh oh!

alexcrichton commented Mar 10, 2017

Uh oh!

steveklabnik commented Mar 10, 2017

Uh oh!

alexcrichton commented Mar 10, 2017

Uh oh!

bors commented Mar 11, 2017

Uh oh!

alexcrichton commented Mar 16, 2017

Uh oh!

bors commented Mar 16, 2017

Uh oh!

frewsxcv commented Mar 17, 2017

Uh oh!

alexcrichton commented Mar 17, 2017

Uh oh!

alexcrichton commented Mar 17, 2017

Uh oh!

bors commented Mar 17, 2017

Uh oh!

alexcrichton commented Mar 23, 2017

Uh oh!

bors commented Mar 23, 2017

Uh oh!

bors commented Mar 24, 2017

Uh oh!

bors commented Mar 24, 2017

Uh oh!

alexcrichton commented Mar 24, 2017 via email

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

bors commented Mar 25, 2017

Uh oh!

arielb1 commented Mar 25, 2017

Uh oh!

bors commented Mar 26, 2017

Uh oh!

bors commented Mar 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants