Uh oh!
There was an error while loading. Please reload this page.
"on-demandify" privacy and access levels - #40771
Merged
bors merged 3 commits intoMar 26, 2017
Merged
Conversation
eddyb
commented
Mar 23, 2017
Contributor
@bors r+ |
bors
commented
Mar 23, 2017
Collaborator
📌 Commit bc319b6 has been approved by |
eddyb
commented
Mar 23, 2017
Contributor
@bors r- Travis failed |
nikomatsakisforce-pushed
the
issue-40746-privacy-access-levels
branch
from
March 23, 2017 20:47
bc319b6 to
7734c9dCompareI realized that, even in the current system, such reads can't really do any harm. Because they are not part of a task, they will occur no matter what (only tasks can be skipped). If you leak the data you read into a task, that is bad, but that is equally bad if you are in a task. *Writes* to tracked state, on the other hand, should never occur except from within a task (and the task then records what things you read to compute it). Once we complete the shift to on-demand, these properties will hold by construction (because the on-demand struct enforces stateless tasks where leaks are impossible -- except by having shared mutable state in the tcx).
nikomatsakisforce-pushed
the
issue-40746-privacy-access-levels
branch
from
March 23, 2017 23:11
7734c9d to
a9f6babComparenikomatsakis
commented
Mar 23, 2017
ContributorAuthor
@bors r=eddyb |
bors
commented
Mar 23, 2017
Collaborator
📌 Commit a9f6bab has been approved by |
63 tasks
bors
commented
Mar 25, 2017
Collaborator
⌛ Testing commit a9f6bab with merge ab05f3a... |
arielb1
commented
Mar 25, 2017
Contributor
@bors retry |
bors
commented
Mar 25, 2017
Collaborator
⌛ Testing commit a9f6bab with merge 2625af4... |
bors
commented
Mar 25, 2017
Collaborator
💔 Test failed - status-travis |
arielb1
commented
Mar 25, 2017
Contributor
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 25, 2017
…cess-levels, r=eddyb "on-demandify" privacy and access levels r? @eddyb cc @cramertjrust-lang#40746
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 25, 2017
…cess-levels, r=eddyb "on-demandify" privacy and access levels r? @eddyb cc @cramertjrust-lang#40746
arielb1
commented
Mar 25, 2017
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb
cc @cramertj#40746