appveyor: Use Ninja/sccache on MSVC by alexcrichton · Pull Request #41447 · rust-lang/rust

alexcrichton · 2017-04-21T14:18:49Z

Now that the final bug fixes have been merged into sccache we can start
leveraging sccache on the MSVC builders on AppVeyor instead of relying on the
ad-hoc caching strategy of trigger files and whatnot.

rust-highfive · 2017-04-21T14:18:54Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-04-21T14:19:30Z

Note that after this we'll finally be using sccache on 100% of our platforms, yay for consistent caching solutions!

nagisa · 2017-04-24T20:57:34Z

Use PathBuf::set_file_name instead.

nagisa · 2017-04-24T20:58:15Z

Use expect with at least somewhat greppable string.

nagisa · 2017-04-24T20:59:22Z

Doesn’t this ignore the path to sccache that can be specified in the config.toml?

nagisa · 2017-04-24T21:01:25Z

Didn’t look at changes to yaml/Dockerfiles. Commented for the rest.

brson · 2017-04-25T17:20:20Z

@bors r+

bors · 2017-04-25T17:20:21Z

📌 Commit d75528e has been approved by brson

…brson appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.

Rollup of 7 pull requests - Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550 - Failed merges:

alexcrichton · 2017-04-26T19:02:06Z

@bors: r=brson

bors · 2017-04-26T19:02:06Z

📌 Commit 970e2a9 has been approved by brson

bors · 2017-04-27T06:18:47Z

⌛ Testing commit 970e2a9 with merge 3fa950c...

bors · 2017-04-27T06:31:55Z

💔 Test failed - status-appveyor

aidanhs · 2017-04-27T09:02:39Z

@bors retry

Appveyor network issues https://appveyor.statuspage.io/incidents/06gzq846jl9x

bors · 2017-04-27T10:32:20Z

⌛ Testing commit 970e2a9 with merge 0f9d66f...

bors · 2017-04-27T10:47:53Z

💔 Test failed - status-appveyor

TimNN · 2017-04-27T10:49:54Z

Legitimate failure, I think:

[00:13:08] The C compiler "C:/projects/rust/build/bootstrap/debug/sccache-plus-cl.exe"
[00:13:08] is not able to compile a simple test program.
[00:13:08] [00:13:08] It fails with the following output:
[00:13:08] [00:13:08] Change Dir: C:/projects/rust/build/i686-pc-windows-msvc/llvm/build/CMakeFiles/CMakeTmp
[00:13:08] [00:13:08] [00:13:08] [00:13:08] Run Build Command:"C:/projects/rust/ninja.exe" "cmTC_1269f"
[00:13:08] [00:13:08] [1/2] Building C object CMakeFiles\cmTC_1269f.dir\testCCompiler.c.obj
[00:13:08] [00:13:08] cl : Command line warning D9025 : overriding '/MD' with '/MDd'
[00:13:08] [00:13:08] cl : Command line warning D9025 : overriding '/MD' with '/MDd'
[00:13:08] [00:13:08] [2/2] Linking C executable cmTC_1269f.exe
[00:13:08] [00:13:08] FAILED: cmTC_1269f.exe [00:13:08] [00:13:08] cmd.exe /C "cd . && "C:\Program Files (x86)\CMake\bin\cmake.exe" -E
[00:13:08] vs_link_exe --intdir=CMakeFiles\cmTC_1269f.dir --manifests --
[00:13:08] C:\PROGRA~2\MI0E91~1.0\VC\bin\amd64\link.exe /nologo
[00:13:08] CMakeFiles\cmTC_1269f.dir\testCCompiler.c.obj /out:cmTC_1269f.exe
[00:13:08] /implib:cmTC_1269f.lib /pdb:cmTC_1269f.pdb /version:0.0 /machine:x64 /debug
[00:13:08] /INCREMENTAL /subsystem:console kernel32.lib user32.lib gdi32.lib
[00:13:08] winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib
[00:13:08] advapi32.lib && cd ."
[00:13:08] [00:13:08] testCCompiler.c.obj : error LNK2001: unresolved external symbol
[00:13:08] _RTC_InitBase
[00:13:08] [00:13:08] testCCompiler.c.obj : error LNK2001: unresolved external symbol
[00:13:08] _RTC_Shutdown
[00:13:08] [00:13:08] LINK : error LNK2001: unresolved external symbol mainCRTStartup
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\kernel32.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\user32.lib :
[00:13:08] warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\gdi32.lib :
[00:13:08] warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\winspool.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\shell32.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\ole32.lib :
[00:13:08] warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\oleaut32.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\comdlg32.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Windows Kits\10\lib\10.0.14393.0\um\x86\advapi32.lib
[00:13:08] : warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\lib\MSVCRTD.lib :
[00:13:08] warning LNK4272: library machine type 'X86' conflicts with target machine
[00:13:08] type 'x64'
[00:13:08] [00:13:08] cmTC_1269f.exe : fatal error LNK1120: 3 unresolved externals
[00:13:08] [00:13:08] LINK Pass 1 failed. with 1120
[00:13:08] [00:13:08] ninja: build stopped: subcommand failed.

This build is no longer a forked version with temporary bugfixes, everything should be upstreamed!

Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.

alexcrichton · 2017-04-27T14:19:49Z

@bors: r=brson

bors · 2017-04-27T14:19:49Z

📌 Commit 2e72bcb has been approved by brson

…brson appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.

bors · 2017-04-27T16:38:26Z

⌛ Testing commit 2e72bcb with merge 94e884b...

appveyor: Use Ninja/sccache on MSVC Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.

bors · 2017-04-27T19:46:07Z

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 94e884b to master...

Pulls in mozilla/sccache@ef0d77543 to fixrust-lang#40240 again after the builds included in rust-lang#41447 forgot to include the mio fixed included in rust-lang#41076. Closesrust-lang#40240

ci: Update sccache build Pulls in mozilla/sccache@ef0d77543 to fix#40240 again after the builds included in #41447 forgot to include the mio fixed included in #41076. Closes#40240

rust-highfive assigned aturon Apr 21, 2017

Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2017

nagisa reviewed Apr 24, 2017
View reviewed changes

Comment threadsrc/bootstrap/native.rs Outdated
nagisaApr 24, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use PathBuf::set_file_name instead.

nagisa reviewed Apr 24, 2017
View reviewed changes

Comment threadsrc/bootstrap/native.rs Outdated
nagisaApr 24, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use expect with at least somewhat greppable string.

nagisa reviewed Apr 24, 2017
View reviewed changes

alexcrichton force-pushed the sccache-everywhere branch from c797287 to d75528eCompare April 25, 2017 05:47

frewsxcv mentioned this pull request Apr 26, 2017
Rollup of 9 pull requests #41554
Closed

alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2017

frewsxcv mentioned this pull request Apr 26, 2017
Rollup of 7 pull requests #41558
Closed

bors added a commit that referenced this pull request Apr 26, 2017
Auto merge of#41558- frewsxcv:rollup, r=frewsxcv
30081ed
Rollup of 7 pull requests - Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550 - Failed merges:

alexcrichton force-pushed the sccache-everywhere branch from d75528e to 970e2a9Compare April 26, 2017 19:01

travis: Update sccache build used
499b84a
This build is no longer a forked version with temporary bugfixes, everything should be upstreamed!

appveyor: Use Ninja/sccache on MSVC
2e72bcb
Now that the final bug fixes have been merged into sccache we can start leveraging sccache on the MSVC builders on AppVeyor instead of relying on the ad-hoc caching strategy of trigger files and whatnot.

alexcrichton force-pushed the sccache-everywhere branch from 970e2a9 to 2e72bcbCompare April 27, 2017 14:19

arielb1 mentioned this pull request Apr 27, 2017
Rollup of 10 pull requests #41579
Closed

bors merged commit 2e72bcb into rust-lang:masterApr 27, 2017

alexcrichton mentioned this pull request Apr 29, 2017
ci: Update sccache build #41623
Merged

alexcrichton deleted the sccache-everywhere branch May 4, 2017 16:40

Uh oh!

Uh oh!

Conversation

alexcrichton commented Apr 21, 2017

Uh oh!

rust-highfive commented Apr 21, 2017

Uh oh!

alexcrichton commented Apr 21, 2017

Uh oh!

nagisaApr 24, 2017

Choose a reason for hiding this comment

Uh oh!

nagisaApr 24, 2017

Choose a reason for hiding this comment

Uh oh!

nagisaApr 24, 2017

Choose a reason for hiding this comment

Uh oh!

nagisa commented Apr 24, 2017

Uh oh!

brson commented Apr 25, 2017

Uh oh!

bors commented Apr 25, 2017

Uh oh!

alexcrichton commented Apr 26, 2017

Uh oh!

bors commented Apr 26, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

aidanhs commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

TimNN commented Apr 27, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcrichton commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

bors commented Apr 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

TimNN commented Apr 27, 2017•
edited
Loading