Skip to content

Invalid module location - #41501

Merged
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:invalid_module_location
Apr 27, 2017
Merged

Invalid module location#41501
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:invalid_module_location

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@carols10centscarols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2017

@jseyfriedjseyfried left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me modulo comment.

Comment threadsrc/libsyntax/parse/parser.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? It looks good as is.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase error I guess. Removing it.

@GuillaumeGomez
GuillaumeGomezforce-pushed the invalid_module_location branch from 3bb4a84 to 3f97b2aCompareApril 25, 2017 10:21
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors: r=jseyfried

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 3f97b2a has been approved by jseyfried

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
@arielb1arielb1 mentioned this pull request Apr 25, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
bors added a commit that referenced this pull request Apr 26, 2017
Rollup of 7 pull requests
- Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
@arielb1arielb1 mentioned this pull request Apr 26, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
@arielb1arielb1 mentioned this pull request Apr 26, 2017
bors added a commit that referenced this pull request Apr 27, 2017
Rollup of 9 pull requests
- Successful merges: #41370, #41456, #41493, #41499, #41501, #41524, #41546, #41550, #41552
- Failed merges:
@bors
bors merged commit 3f97b2a into rust-lang:masterApr 27, 2017
@GuillaumeGomez
GuillaumeGomez deleted the invalid_module_location branch April 27, 2017 14:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@bors@jseyfried@carols10cents