Skip to content

Haiku: fix initial platform support - #41456

Merged
bors merged 2 commits into
rust-lang:masterfrom
jessicah:haiku-support
Apr 27, 2017
Merged

Haiku: fix initial platform support#41456
bors merged 2 commits into
rust-lang:masterfrom
jessicah:haiku-support

Conversation

@jessicah

@jessicahjessicah commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Apr 22, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2017
@Mark-Simulacrum

Mark-Simulacrum commented Apr 22, 2017

Copy link
Copy Markdown
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @pnkfelix or someone else from the team reviews it soon.

@jessicah

jessicah commented Apr 23, 2017

Copy link
Copy Markdown
ContributorAuthor

Just found a few more changes I need to make, so not yet ready for merging.

@alexcrichton

alexcrichton commented Apr 24, 2017

Copy link
Copy Markdown
Member

@jessicah this looks good to me, is it ready to merge?

@jessicah

jessicah commented Apr 25, 2017

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton yes, it's ready to merge :)

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 25, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0d63f13 has been approved by alexcrichton

@jessicah

jessicah commented Apr 25, 2017

Copy link
Copy Markdown
ContributorAuthor

Will it merge with the checks failed? I had pushed three commits, then undid the last one, so the second commit never got checked.

@alexcrichton

alexcrichton commented Apr 25, 2017

Copy link
Copy Markdown
Member

Yeah that's ok, @bors will re-check against the latest master once this reaches the head of the queue: https://buildbot2.rust-lang.org/homu/queue/rust

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41456- jessicah:haiku-support, r=alexcrichton
f7ad2df
Haiku: fix initial platform support
@arielb1arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge ofrust-lang#41456- jessicah:haiku-support, r=alexcrichton
64eebc9
Haiku: fix initial platform support
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge ofrust-lang#41456- jessicah:haiku-support, r=alexcrichton
91ebac3
Haiku: fix initial platform support
@frewsxcvfrewsxcv mentioned this pull request Apr 26, 2017
Closed
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of#41558- frewsxcv:rollup, r=frewsxcv
30081ed
Rollup of 7 pull requests
- Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41456- jessicah:haiku-support, r=alexcrichton
5d8ab6b
Haiku: fix initial platform support
@arielb1arielb1 mentioned this pull request Apr 26, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Ariel Ben-Yehuda
Rollup merge ofrust-lang#41456- jessicah:haiku-support, r=alexcrichton
639000e
Haiku: fix initial platform support
@arielb1arielb1 mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 27, 2017
@bors
Auto merge of#41567- arielb1:rollup, r=arielb1
6e0c5af
Rollup of 9 pull requests
- Successful merges: #41370, #41456, #41493, #41499, #41501, #41524, #41546, #41550, #41552
- Failed merges:
@bors
bors merged commit 0d63f13 into rust-lang:masterApr 27, 2017
@jessicah
jessicah deleted the haiku-support branch September 6, 2017 19:43
@workingjubileeworkingjubilee added the O-haiku Target: Be extant; from mouldering old leaves; spring arrives again label Jul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

O-haikuTarget: Be extant; from mouldering old leaves; spring arrives againS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jessicah@rust-highfive@Mark-Simulacrum@alexcrichton@bors@pnkfelix@workingjubilee