Skip to content

add FromStr Impl for char - #42271

Merged
bors merged 1 commit into
rust-lang:masterfrom
tinaun:charfromstr
Jun 21, 2017
Merged

add FromStr Impl for char#42271
bors merged 1 commit into
rust-lang:masterfrom
tinaun:charfromstr

Conversation

@tinaun

@tinauntinaun commented May 27, 2017

Copy link
Copy Markdown
Contributor

fixes#24939.

is it possible to use pub(restricted) instead of using a stability attribute for the internal error representation? is it needed at all?

@tinaun
tinaunforce-pushed the charfromstr branch 2 times, most recently from 3af38df to 13c89a9CompareMay 28, 2017 02:39
@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2017
@frewsxcvfrewsxcv added the T-libs-api [DEPRECATED; DO NOT USE] label May 28, 2017
@alexcrichton

alexcrichton commented May 30, 2017

Copy link
Copy Markdown
Member

This looks pretty reasonable to me, thanks for the PR @tinaun! I'll...

@rfcbot fcp merge

@alexcrichton

alexcrichton commented May 30, 2017

Copy link
Copy Markdown
Member

is it possible to use pub(restricted) instead of using a stability attribute for the internal error representation? is it needed at all?

Currently the way to work across crates is stability attributes, so this is ok. If we decide to land this though the FromStr for char impl block will be "insta stable" in the sense that the #[unstable] attribute is basically ignored. Could you change that and the error type as well to #[stable], along with the impls on the error type itself?

@rfcbot

rfcbot commented May 30, 2017•
edited by BurntSushi
Loading

Copy link
Copy Markdown

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@BurntSushi

BurntSushi commented May 30, 2017

Copy link
Copy Markdown
Member

If we stabilize the impl then we should also stabilize the error type?

@alexcrichton

alexcrichton commented May 30, 2017

Copy link
Copy Markdown
Member

That's what I'm thinking, yeah.

@alexcrichton

alexcrichton commented May 31, 2017

Copy link
Copy Markdown
Member

Changes look good to me, thanks @tinaun!

@rfcbotrfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 6, 2017
@rfcbot

rfcbot commented Jun 6, 2017

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@Mark-Simulacrum

Mark-Simulacrum commented Jun 11, 2017

Copy link
Copy Markdown
Member

@alexcrichton I think this is good to go, but I'm not sure if I understand the rfcbot process on PRs 100% so not going to r=you myself.

alexcrichton
alexcrichton reviewed Jun 13, 2017
View reviewed changes
Comment threadsrc/libcore/char.rs Outdated

@alexcrichtonalexcrichtonJun 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be conservative, could this remove Copy, PartialEq, and Eq?

@tinauntinaunJun 13, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@alexcrichton

alexcrichton commented Jun 13, 2017

Copy link
Copy Markdown
Member

Ah no worries @Mark-Simulacrum. @tinaun I added one minor comment about the error type but otherwise this should be good to go.

@alexcrichton

alexcrichton commented Jun 13, 2017

Copy link
Copy Markdown
Member

@tinaun oh it's ok to leave Clone I'd just remove Copy, basically I'd just have #[derive(Debug, Clone)]

@tinaun

tinaun commented Jun 14, 2017

Copy link
Copy Markdown
ContributorAuthor

whoops, totally thought i removed copy

@alexcrichton

alexcrichton commented Jun 14, 2017

Copy link
Copy Markdown
Member

Ah it looks like some of the tests are failing with the removal of PartialEq, want to add some unwrap() annotations to get them compiling again?

@rfcbot

rfcbot commented Jun 16, 2017

Copy link
Copy Markdown

The final comment period is now complete.

@tinaun

tinaun commented Jun 20, 2017

Copy link
Copy Markdown
ContributorAuthor

fixed; squashed.

@alexcrichton

alexcrichton commented Jun 20, 2017

Copy link
Copy Markdown
Member

@bors: r+

Thanks!

@bors

bors commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit fd9d7aa has been approved by alexcrichton

@Mark-Simulacrum

Mark-Simulacrum commented Jun 20, 2017

Copy link
Copy Markdown
Member

@bors rollup

@arielb1arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 20, 2017
@frewsxcv
Rollup merge ofrust-lang#42271- tinaun:charfromstr, r=alexcrichton
4c43bc3
add `FromStr` Impl for `char`
fixesrust-lang#24939.
is it possible to use pub(restricted) instead of using a stability attribute for the internal error representation? is it needed at all?
@frewsxcvfrewsxcv mentioned this pull request Jun 20, 2017
Merged
bors added a commit that referenced this pull request Jun 20, 2017
@bors
Auto merge of#42780- frewsxcv:rollup, r=frewsxcv
4450779
Rollup of 6 pull requests
- Successful merges: #42271, #42717, #42728, #42749, #42756, #42772
- Failed merges:
@bors
bors merged commit fd9d7aa into rust-lang:masterJun 21, 2017
@tinaun
tinaun deleted the charfromstr branch June 21, 2017 01:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichtonalexcrichtonalexcrichton left review comments

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FromStr is not implemented for char

8 participants

@tinaun@alexcrichton@rfcbot@BurntSushi@Mark-Simulacrum@bors@frewsxcv@arielb1