Additions/improvements for doc examples.

[frewsxcv]

No description provided.

[carols10cents]

r? @GuillaumeGomez

[ollie27]

How about adding an example for the invalid Unicode case? Either way is definitely wouldn't return Cow::Borrowed it would return Cow::Owned.

[frewsxcv]

I figured it'd be undefined behavior to create a string w/ invalid unicode, as your comment here.

Either way is definitely wouldn't return Cow::Borrowed it would return Cow::Owned.

Yep, good catch, I'll change that

[ollie27]

I figured it'd be undefined behavior to create a string w/ invalid unicode

Strings and strs have to contain valid UTF-8 but CStrings and Cstrs are just sequences of any none null bytes. The following example would be fine:

use std::borrow::Cow;use std::ffi::CStr;let c_str = CStr::from_bytes_with_nul(b"foo\xc3\0").unwrap();assert_eq!(c_str.to_string_lossy(),"foo�");

It would also be more correct to say "(in)valid UTF-8" rather than "(in)valid unicode" in this case.

[QuietMisdreavus]

It might be worth borrowing from the example in String::from_utf8_lossy, which uses the input string b"Hello \xF0\x90\x80World" to demonstrate the replacement.

[QuietMisdreavus]

Looks good, other than the discussion surrounding to_string_lossy. If you can update those examples (on both CStr and OsStr) then I'm okay with everything else.

[frewsxcv]

Looks good, other than the discussion surrounding to_string_lossy. If you can update those examples (on both CStr and OsStr) then I'm okay with everything else.

Fixed the failing doc test and updated the CStr::to_string_lossy examples. I ditched my changes to OsStr. I don't think there's a way to create an OsStr from bytes (in a cross platform manner) like we can for CStr so I don't know how to demonstrate an OsStr containing invalid UTF8.

[kennytm]

Could you change this to ```no_run? Also the some_external_function(raw) on line 307 should be some_extern_function(raw).

[frewsxcv]

I think I'll get linker errors upon building, right?

[frewsxcv]

Latest force push addresses the typo, good catch

[kennytm]

@frewsxcv Currently no_run (and compile_fail as well) will stop after analysis. It won't even run codegen.

[frewsxcv]

Changed ignore to no_run in the latest force push

[bors]

☔ The latest upstream changes (presumably #42716) made this pull request unmergeable. Please resolve the merge conflicts.

[frewsxcv]

Rebased, addressed merge conflicts

[QuietMisdreavus]

@bors r+

[bors]

📌 Commit 58bbe1d has been approved by QuietMisdreavus

[frewsxcv]

@bors rollup