Skip to content

Rollup of 6 pull requests - #42780

Merged
bors merged 23 commits into
rust-lang:masterfrom
frewsxcv:rollup
Jun 21, 2017
Merged

Rollup of 6 pull requests#42780
bors merged 23 commits into
rust-lang:masterfrom
frewsxcv:rollup

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

ollie27and others added 23 commits June 17, 2017 20:49
@ollie27
Convert Into<Box<[T]>> for Vec<T> into From<Vec<T>> for Box<[T]>
222a328
@jseyfried
resolve: fix perf bug.
3c1af32
@sanxiyn
Show type name for unused_must_use lint
05540bf
@tinaun
added FromStr Impl for char
fd9d7aa
@MaloJaffre
Update libc to 0.2.24
174a7fc
Fixesrust-lang#42427.
@frewsxcv
Add doc example for CStr::to_bytes.
0fad2e0
@frewsxcv
Add doc example for CStr::to_bytes_with_nul.
7f687f8
@frewsxcv
Add error scenario doc examples for CStr::from_bytes_with_nul.
5d71e8c
@frewsxcv
Add doc example for CStr::to_string_lossy.
82ba871
@frewsxcv
Add doc example for CString::into_boxed_c_str.
db97145
@frewsxcv
Add doc example for Box<CStr>::into_c_string.
65793b3
@frewsxcv
Add doc example for CString::as_c_str.
0962394
@frewsxcv
Add doc example for CStr::to_str.
e52d2f2
@frewsxcv
Add doc example for NulError.
4797d84
@frewsxcv
Add doc example for FromBytesWithNulError.
d3c26fe
@frewsxcv
Add doc example for CString::from_raw.
93abc2f
@frewsxcv
Add a couple doc additional examples for env::join_paths.
58bbe1d
@frewsxcv
Rollup merge ofrust-lang#42271- tinaun:charfromstr, r=alexcrichton
4c43bc3
add `FromStr` Impl for `char`
fixesrust-lang#24939.
is it possible to use pub(restricted) instead of using a stability attribute for the internal error representation? is it needed at all?
@frewsxcv
Rollup merge ofrust-lang#42717- ollie27:into_to_from2, r=sfackler
dbe16e0
Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>`
As the `collections` crate has been merged into `alloc` in rust-lang#42648 this impl is now possible. This is the final part of rust-lang#42129 missing from rust-lang#42227.
@frewsxcv
Rollup merge ofrust-lang#42728- jseyfried:fix_resolve_perf, r=nrc
d92edac
resolve: fix perf bug
Fixesrust-lang#42544.
r? @nrc
@frewsxcv
Rollup merge ofrust-lang#42749- frewsxcv:frewsxcxv/doc-examples, r=…
d3e116a
…QuietMisdreavus
Additions/improvements for doc examples.
None
@frewsxcv
Rollup merge ofrust-lang#42756- sanxiyn:name-for-must-use, r=estebank
f9edbcc
Show type name for unused_must_use lint
Fixrust-lang#42688.
@frewsxcv
Rollup merge ofrust-lang#42772- MaloJaffre:libc, r=alexcrichton
58425ef
Update libc to 0.2.24
Fixesrust-lang#42427.
@frewsxcv

frewsxcv commented Jun 20, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=10

@bors

bors commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 58425ef has been approved by frewsxcv

@rust-highfive

rust-highfive commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 20, 2017
@bors

bors commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 58425ef with merge 4450779...

bors added a commit that referenced this pull request Jun 20, 2017
@bors
Auto merge of#42780- frewsxcv:rollup, r=frewsxcv
4450779
Rollup of 6 pull requests
- Successful merges: #42271, #42717, #42728, #42749, #42756, #42772
- Failed merges:
@bors

bors commented Jun 21, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 4450779 to master...

@bors
bors merged commit 58425ef into rust-lang:masterJun 21, 2017
@borsbors mentioned this pull request Jun 21, 2017
Closed
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@frewsxcv@bors@rust-highfive@alexcrichton@Centril@arielb1@ollie27@jseyfried@sanxiyn@tinaun@MaloJaffre