Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #42272
Closed
Mark-Simulacrum wants to merge 16 commits into
Closed
Conversation
This should include a fix for rust-lang/cargo#4091 with an updated version of libgit2. Closesrust-lang/cargo#4091
Mark various items and fields as private or pub(crate), and remove a function that turns out to be unused. These are not used anywhere in-tree, but I guess it's a [breaking-change] for plugins.
The previous commit removed them from the public API, this rewrites the use statements to get rid of the non-standard re-exports.
…eddyb Remove all instances of fragment_infos and fragment sets Remove unused fragment structs. This was suggested by @eddyb in IRC: [botbot link](https://botbot.me/mozilla/rustc/2017-05-23/?msg=86016574&page=2).
…ulacrum regression test for rust-lang#39974closesrust-lang#39974 r? @Mark-Simulacrum
…tsakis Updated locked version of libgit2 This should include a fix for rust-lang/cargo#4091 with an updated version of libgit2. Closesrust-lang/cargo#4091
Allow variadic functions with cdecl calling convention. Fixesrust-lang#40244.
…ed-tail, r=eddyb extend `struct_tail` to operate over tuples Not 100% sure why this got exposed when it wasn't before, but this struct definitely seems wrong. Fixesrust-lang#42110 r? @eddyb
…ent, r=alexcrichton Docs: impls of PartialEq/PartialOrd/Ord must agree Fixesrust-lang#41270. This PR brings two improvements to the docs: 1. Docs for `PartialEq`, `PartialOrd`, and `Ord` clarify that their implementations must agree. 2. Fixes a subtle bug in the Dijkstra example for `BinaryHeap`, where the impls are inconsistent. Thanks @Rufflewind for spotting the bug! r? @alexcrichton cc @frankmcsherry
Remove unused APIs from rustc_trans There were public re-exports of some rustc modules dating back to 2011 or so. While I was at it, some functions and modules were public but never used outside the crate. I made them private or `pub(crate)` as appropriate and in one case removed an unused function.
rust-highfive
commented
May 28, 2017
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 28, 2017
MemberAuthor
@bors r+ p=10 |
bors
commented
May 28, 2017
Collaborator
📌 Commit 5244d1c has been approved by |
bors
commented
May 28, 2017
Collaborator
⌛ Testing commit 5244d1c with merge e9a48f4... |
bors
commented
May 28, 2017
Collaborator
💔 Test failed - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct_tailto operate over tuples #42251, Docs: impls of PartialEq/PartialOrd/Ord must agree #42260, Remove unused APIs from rustc_trans #42266